Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7403

should not pass recv_writer_thread_handle to CloseHandle()

Details

    Description

      Calling CloseHandle on an invalid handle. See here:

      UNIV_INTERN os_thread_t recv_writer_thread_handle = 0;

      recv_init_crash_recovery() does:

      recv_writer_thread_handle = os_thread_create(recv_writer_thread, 0, 0);

      recv_recovery_from_checkpoint_finish() does:

      if (recv_writer_thread_handle)

      { CloseHandle(recv_writer_thread_handle); }

      However, os_thread_create() is not returning the HANDLE object from CreateThread, it is returning the lpThreadId!!!

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          sbester1 sbester1 created issue -
          sbester1 sbester1 made changes -
          Field Original Value New Value
          Affects Version/s 10.0.15 [ 17300 ]
          elenst Elena Stepanova made changes -
          Fix Version/s 10.0 [ 16000 ]
          Assignee Jan Lindström [ jplindst ]
          serg Sergei Golubchik made changes -
          Priority Trivial [ 5 ] Major [ 3 ]
          jplindst Jan Lindström (Inactive) made changes -
          Fix Version/s 10.0.16 [ 17900 ]
          Fix Version/s 10.0 [ 16000 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 59104 ] MariaDB v3 [ 62204 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 62204 ] MariaDB v4 [ 148676 ]

          People

            jplindst Jan Lindström (Inactive)
            sbester1 sbester1
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.