Details
-
Task
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
10.2.0-1
Description
MariaDB 10.1 still ships the tool "mysql_zap.sh" on the "scripts/" directory.
This tool basically does what the "pkill" tool does with the "-f" switch : killing processes whose name match a certain string.
The way the script match the processes it needs to kill isnt clean (using the output of a "ps" command), it outputs an stty error message when executed, doesnt output any warning after trying to kill processes the user doesnt own and waits at least 2 seconds after each kills which renders it unpractical.
The script doesnt seems to be called at any point on the MariaDB sources, doesnt do any MariaDB related job and is most probably not used anymore.
Attachments
Issue Links
- relates to
-
-
- Closed
-
- links to
Activity
I don't think I need to review it, push when you're think it's ok.
Yes, he did.
Sure, thanks for taking it.
Just a note:
A important distinction between pkill and mysql_zap is that mysql_zap kills the server 'gently' first (with signal 15) and only if the server doesn't die in a limited time then tries -9.
To use pkill one must run it twice; pkill --signal 15 mysqld ; sleep(10) ; pkill -f --signal 9 pattern
So in the end, pkill is more cumbersome and slower to use than mysql_zap to kill the mysqld server.
serg, please review patch for this task. Did monty agree with this clean-up?
Sorry for stealing it, I assume you don't have it implemented in your tree.