Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7225

sql bench test-transactions does not run on tokudb

Details

    • 1.0.2

    Description

      ./test-transactions --create-options=engine=tokudb --socket=/tmp/rfp.sock
      		 
      Testing server 'MySQL 10.0.15 MariaDB debug' at 2014-11-27  7:43:58
      		 
       
      		 
      Test skipped because the database doesn't support transactions

      Needs this fix:
      https://github.com/Tokutek/mariadb-10.0/commit/4dc93065ff41d57c71396ff55a32598d42e1ac9d

      Attachments

        Issue Links

          links to

          Web Link GitHub Pull Request #192

          Activity

            Ascending order - Click to sort in descending order
            prohaska7 Rich Prohaska created issue -
            prohaska7 Rich Prohaska made changes -
            Field Original Value New Value
            Component/s Tests [ 10800 ]
            elenst Elena Stepanova made changes -
            Fix Version/s 10.0 [ 16000 ]
            Assignee Sergei Golubchik [ serg ]
            Summary sql bench test-transactions does not run on tokudb [PATCH] sql bench test-transactions does not run on tokudb
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 58746 ] MariaDB v3 [ 65440 ]
            danblack Daniel Black added a comment -

            the fix link is now broken. Cannot easily see this in the mariadb-server repo of the same commit id either.

            danblack Daniel Black added a comment - the fix link is now broken. Cannot easily see this in the mariadb-server repo of the same commit id either.
            serg Sergei Golubchik added a comment -

            even without the link, I suppose, the patch was to edit sql-bench/server-cfg that sets various flags based on the engine name, and add there something like

              if (defined($main::opt_create_options) &&
            		 
                  $main::opt_create_options =~ /engine=tokudb/i)
            		 
              {
            		 
                $self->{'transactions'}	= 1;	# Transactions enabled
            		 
              }

            serg Sergei Golubchik added a comment - even without the link, I suppose, the patch was to edit sql-bench/server-cfg that sets various flags based on the engine name, and add there something like if ( defined ( $main ::opt_create_options) && $main ::opt_create_options =~ /engine=tokudb/i) { $self ->{ 'transactions' } = 1; # Transactions enabled }
            prohaska7 Rich Prohaska added a comment -

            Yes, that is the patch and this pull request works on 10.1: https://github.com/MariaDB/server/pull/192

            prohaska7 Rich Prohaska added a comment - Yes, that is the patch and this pull request works on 10.1: https://github.com/MariaDB/server/pull/192
            svoj Sergey Vojtovich made changes -
            svoj Sergey Vojtovich made changes -
            Summary [PATCH] sql bench test-transactions does not run on tokudb sql bench test-transactions does not run on tokudb
            svoj Sergey Vojtovich added a comment -

            Updated fix version to 10.1 since PR is against 10.1.

            svoj Sergey Vojtovich added a comment - Updated fix version to 10.1 since PR is against 10.1.
            svoj Sergey Vojtovich made changes -
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.0 [ 16000 ]
            svoj Sergey Vojtovich made changes -
            Affects Version/s 10.1.14 [ 21804 ]
            svoj Sergey Vojtovich made changes -
            Labels contribution foundation
            svoj Sergey Vojtovich made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            prohaska7 Rich Prohaska added a comment -

            I just emailed a signed mariadb contributor agreement.

            prohaska7 Rich Prohaska added a comment - I just emailed a signed mariadb contributor agreement.
            svoj Sergey Vojtovich added a comment -

            MCA received, thanks!

            svoj Sergey Vojtovich added a comment - MCA received, thanks!
            serg Sergei Golubchik made changes -
            Sprint 10.1.16 [ 76 ]
            serg Sergei Golubchik made changes -
            Rank Ranked lower
            serg Sergei Golubchik made changes -
            Description ./test-transactions --create-options=engine=tokudb --socket=/tmp/rfp.sock
            Testing server 'MySQL 10.0.15 MariaDB debug' at 2014-11-27 7:43:58

            Test skipped because the database doesn't support transactions

            Needs this fix:
            https://github.com/Tokutek/mariadb-10.0/commit/4dc93065ff41d57c71396ff55a32598d42e1ac9d             		{noformat}
            ./test-transactions --create-options=engine=tokudb --socket=/tmp/rfp.sock
            Testing server 'MySQL 10.0.15 MariaDB debug' at 2014-11-27 7:43:58

            Test skipped because the database doesn't support transactions
            {noformat}
            Needs this fix:
            https://github.com/Tokutek/mariadb-10.0/commit/4dc93065ff41d57c71396ff55a32598d42e1ac9d
            serg Sergei Golubchik made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            serg Sergei Golubchik made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.27 [ 22017 ]
            Fix Version/s 10.1.16 [ 22019 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.27 [ 22017 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 65440 ] MariaDB v4 [ 148558 ]

            People

              serg Sergei Golubchik
              prohaska7 Rich Prohaska
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.