Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7201

[PATCH] parallel threads resizing - potential race condition to access freed memory

Details

    Description

      pool->threads is freed before being reassigned the new pool.

      Although not really a memory barrier I though it prudent to keep the pool thread count to be the lower of the old/new thread list before the new threads is allocated.

      Patch refers

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          danblack Daniel Black created issue -
          knielsen Kristian Nielsen made changes -
          Field Original Value New Value
          Assignee Kristian Nielsen [ knielsen ]
          danblack Daniel Black made changes -
          Summary parallel threads resizing - potential race condition to access freed memory [PATCH] parallel threads resizing - potential race condition to access freed memory
          serg Sergei Golubchik made changes -
          Fix Version/s 10.1 [ 16100 ]
          knielsen Kristian Nielsen made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          knielsen Kristian Nielsen added a comment -

          Hm. As you say, due to no barriers this doesn't actually make any semantic
          change. But ok, if you think it makes the code clearer, it doesn't hurt
          anything, so I'll push it to 10.1.

          knielsen Kristian Nielsen added a comment - Hm. As you say, due to no barriers this doesn't actually make any semantic change. But ok, if you think it makes the code clearer, it doesn't hurt anything, so I'll push it to 10.1.
          knielsen Kristian Nielsen added a comment -

          Pushed to 10.1.3

          knielsen Kristian Nielsen added a comment - Pushed to 10.1.3
          knielsen Kristian Nielsen made changes -
          Fix Version/s 10.1.3 [ 18000 ]
          Fix Version/s 10.1 [ 16100 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 58721 ] MariaDB v3 [ 64822 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 64822 ] MariaDB v4 [ 132469 ]

          People

            knielsen Kristian Nielsen
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.