[MDEV-7201] [PATCH] parallel threads resizing - potential race condition to access freed memory Created: 2014-11-25  Updated: 2015-02-07  Resolved: 2015-02-07

Status: Closed
Project: MariaDB Server
Component/s: Replication
Fix Version/s: 10.1.3

Type: Task Priority: Major
Reporter: Daniel Black Assignee: Kristian Nielsen
Resolution: Fixed Votes: 0
Labels: parallelslave

Attachments: File parallel_threads_resizing.patch    

 Description   

pool->threads is freed before being reassigned the new pool.

Although not really a memory barrier I though it prudent to keep the pool thread count to be the lower of the old/new thread list before the new threads is allocated.

Patch refers

 Comments   
Comment by Kristian Nielsen [ 2015-02-04 ]

Hm. As you say, due to no barriers this doesn't actually make any semantic
change. But ok, if you think it makes the code clearer, it doesn't hurt
anything, so I'll push it to 10.1.

Comment by Kristian Nielsen [ 2015-02-07 ]

Pushed to 10.1.3

Generated at Thu Feb 08 07:17:46 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.