Type:
Task
Priority:
Major
Resolution:
Fixed
This is a pre-requisite task for:
MDEV-5359 CREATE OR REPLACE, CREATE IF NOT EXISTS, DROP IF EXISTS
HA_CREATE_INFO contains:
DDL options like IF EXISTS and IF NOT EXISTS that are processed before passing information to the handler (for table creation) and are not needed for the handler itself.
Schema specifications (e.g. default character set). This part is needed as a standalone structure, because it is passed to mysql_create_db and mysql_rm_db who don't need the rest of HA_CREATE_INFO. Currently the entire HA_CREATE_INFO is initialized before passing to the schema DDL routines. Also, this part is enough for mysqld_show_create_db. Currently the entire HA_CREATE_INFO is passed again.
So these two parts should be moved out of HA_CREATE_INFO.
Proposed new structure hierarchy:
1. DDL_options_st, to store IF EXISTS, IF NOT EXISTS
This will be shared between all DDL routines (e.g. CREATE TABLE, DROP SCHEMA, etc).
2. Schema_specification_st
This will be passed to mysql_create_db, mysql_drop_db, mysqld_show_create_db
3. Table_contents_source_st, contains everything the old HA_CREATE_INFO had but without DDL options and without Schema_specification_st
4. HA_CREATE_INFO= Table_contents_source_st + Schema_specification_st
This will be passed to handlers
5. Table_specification_st= HA_CREATE_INFO + DDL_options_st
This will be passed to mysql_create_table.
Also, API for some functions has to be changed:
SCHEMA routines: mysql_create_db, mysql_drop_db
TABLE routines: mysql_create_table, mysql_drop_table
and some others. The new structures will now be passed instead of HA_CREATE_INFO
blocks
MDEV-5359
CREATE OR REPLACE, CREATE IF NOT EXISTS, DROP IF EXISTS
Closed
There are no comments yet on this issue.
{"report":{"fcp":3673.899999976158,"ttfb":1328.3999999761581,"pageVisibility":"visible","entityId":48855,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"336c3364-fd97-4dac-8a86-2bf3232a0cee","navigationType":0,"readyForUser":3889.7999999523163,"redirectCount":0,"resourceLoadedEnd":4188.399999976158,"resourceLoadedStart":1351.2999999523163,"resourceTiming":[{"duration":1194.6000000238419,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":1351.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1351.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2545.899999976158,"responseStart":0,"secureConnectionStart":0},{"duration":1194.8999999761581,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1351.6000000238419,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1351.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2546.5,"responseStart":0,"secureConnectionStart":0},{"duration":1208.6000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":1351.6999999284744,"connectEnd":1351.6999999284744,"connectStart":1351.6999999284744,"domainLookupEnd":1351.6999999284744,"domainLookupStart":1351.6999999284744,"fetchStart":1351.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":1351.6999999284744,"responseEnd":2560.2999999523163,"responseStart":2560.2999999523163,"secureConnectionStart":1351.6999999284744},{"duration":1524.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1351.8999999761581,"connectEnd":1351.8999999761581,"connectStart":1351.8999999761581,"domainLookupEnd":1351.8999999761581,"domainLookupStart":1351.8999999761581,"fetchStart":1351.8999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":1351.8999999761581,"responseEnd":2876.1999999284744,"responseStart":2876.1999999284744,"secureConnectionStart":1351.8999999761581},{"duration":1544.3999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":1352.1000000238419,"connectEnd":1352.1000000238419,"connectStart":1352.1000000238419,"domainLookupEnd":1352.1000000238419,"domainLookupStart":1352.1000000238419,"fetchStart":1352.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":1352.1000000238419,"responseEnd":2896.5,"responseStart":2896.5,"secureConnectionStart":1352.1000000238419},{"duration":1545.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":1352.3999999761581,"connectEnd":1352.3999999761581,"connectStart":1352.3999999761581,"domainLookupEnd":1352.3999999761581,"domainLookupStart":1352.3999999761581,"fetchStart":1352.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":1352.3999999761581,"responseEnd":2897.6999999284744,"responseStart":2897.6999999284744,"secureConnectionStart":1352.3999999761581},{"duration":1545.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":1352.5,"connectEnd":1352.5,"connectStart":1352.5,"domainLookupEnd":1352.5,"domainLookupStart":1352.5,"fetchStart":1352.5,"redirectEnd":0,"redirectStart":0,"requestStart":1352.5,"responseEnd":2898,"responseStart":2898,"secureConnectionStart":1352.5},{"duration":1567.6000000238419,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":1352.6999999284744,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1352.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2920.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":1546.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":1352.7999999523163,"connectEnd":1352.7999999523163,"connectStart":1352.7999999523163,"domainLookupEnd":1352.7999999523163,"domainLookupStart":1352.7999999523163,"fetchStart":1352.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":1352.7999999523163,"responseEnd":2899,"responseStart":2899,"secureConnectionStart":1352.7999999523163},{"duration":1567.3999999761581,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":1353,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1353,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2920.399999976158,"responseStart":0,"secureConnectionStart":0},{"duration":1546.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":1353.1000000238419,"connectEnd":1353.1000000238419,"connectStart":1353.1000000238419,"domainLookupEnd":1353.1000000238419,"domainLookupStart":1353.1000000238419,"fetchStart":1353.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":1353.1000000238419,"responseEnd":2899.899999976158,"responseStart":2899.899999976158,"secureConnectionStart":1353.1000000238419},{"duration":2150.6999999284744,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":1354,"connectEnd":1354,"connectStart":1354,"domainLookupEnd":1354,"domainLookupStart":1354,"fetchStart":1354,"redirectEnd":0,"redirectStart":0,"requestStart":1354,"responseEnd":3504.6999999284744,"responseStart":3504.6999999284744,"secureConnectionStart":1354},{"duration":2834.399999976158,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":1354,"connectEnd":1354,"connectStart":1354,"domainLookupEnd":1354,"domainLookupStart":1354,"fetchStart":1354,"redirectEnd":0,"redirectStart":0,"requestStart":1354,"responseEnd":4188.399999976158,"responseStart":4188.399999976158,"secureConnectionStart":1354},{"duration":570.5999999046326,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":2935.600000023842,"connectEnd":2935.600000023842,"connectStart":2935.600000023842,"domainLookupEnd":2935.600000023842,"domainLookupStart":2935.600000023842,"fetchStart":2935.600000023842,"redirectEnd":0,"redirectStart":0,"requestStart":2935.600000023842,"responseEnd":3506.1999999284744,"responseStart":3506.1999999284744,"secureConnectionStart":2935.600000023842}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":1183,"responseStart":1329,"responseEnd":1335,"domLoading":1350,"domInteractive":4281,"domContentLoadedEventStart":4281,"domContentLoadedEventEnd":4344,"domComplete":5318,"loadEventStart":5319,"loadEventEnd":5319,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":4200.699999928474},{"name":"bigPipe.sidebar-id.end","time":4212.899999976158},{"name":"bigPipe.activity-panel-pipe-id.start","time":4213.100000023842},{"name":"bigPipe.activity-panel-pipe-id.end","time":4213.600000023842},{"name":"activityTabFullyLoaded","time":4358.299999952316}],"measures":[],"correlationId":"3a8eb3c18bd79b","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":90,"dbReadsTimeInMs":12,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}