Details
-
Bug
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
5.5.40
-
None
Description
The safety check in my_config.h ensures that this file is always included before system headers.
But when my_config.h is installed, this breaks compilation of various third-party projects. In particular, mysql-python doesn't compile anymore.
While technically forcing my_config.h first is correct and mysql-python doesn't break by a sheer luck and, we still cannot force all third-party projects to include files correctly.
This check has to be relaxed.
Attachments
Issue Links
- relates to
-
MDEV-5120 Test suite test maria-no-logging fails
-
- Closed
-
Activity
Description |
The safety check in {{my_config.h}} ensures that this file is always included before system headers. But when {{my_config.h}} is installed, this breaks compilation of various third-party projects. In particular, mysql-python doesn't compile anymore. While technically forcing {{my_config.h}} is correct and mysql-python doesn't break by a sheer luck and, we still cannot force all third-party projects to include my_config.h first. This check has to be relaxed. |
The safety check in {{my_config.h}} ensures that this file is always included before system headers. But when {{my_config.h}} is installed, this breaks compilation of various third-party projects. In particular, mysql-python doesn't compile anymore. While technically forcing {{my_config.h}} first is correct and mysql-python doesn't break by a sheer luck and, we still cannot force all third-party projects to include my_config.h first. This check has to be relaxed. |
Description |
The safety check in {{my_config.h}} ensures that this file is always included before system headers. But when {{my_config.h}} is installed, this breaks compilation of various third-party projects. In particular, mysql-python doesn't compile anymore. While technically forcing {{my_config.h}} first is correct and mysql-python doesn't break by a sheer luck and, we still cannot force all third-party projects to include my_config.h first. This check has to be relaxed. |
The safety check in {{my_config.h}} ensures that this file is always included before system headers. But when {{my_config.h}} is installed, this breaks compilation of various third-party projects. In particular, mysql-python doesn't compile anymore. While technically forcing {{my_config.h}} first is correct and mysql-python doesn't break by a sheer luck and, we still cannot force all third-party projects to include files correctly. This check has to be relaxed. |
Affects Version/s | 10.0.14 [ 17101 ] |
Fix Version/s | 10.0.15 [ 17300 ] | |
Fix Version/s | 10.0 [ 16000 ] |
Status | Open [ 1 ] | In Progress [ 3 ] |
Fix Version/s | 5.5.41 [ 17600 ] | |
Fix Version/s | 5.5 [ 15800 ] | |
Resolution | Fixed [ 1 ] | |
Status | In Progress [ 3 ] | Closed [ 6 ] |
Component/s | Compiling [ 11001 ] | |
Component/s | OTHER [ 10125 ] |
Workflow | MariaDB v2 [ 55700 ] | MariaDB v3 [ 65225 ] |
Workflow | MariaDB v3 [ 65225 ] | MariaDB v4 [ 148302 ] |