Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6800

auth_socket plugin fails to build on OpenBSD with MariaDB 10.0.14

Details

    Description

      The auth_socket plugin as of 10.0.14 now fails to build on OpenBSD.

      [1129/1310] /usr/bin/cc  -DHAVE_CONFIG_H -DHAVE_SOCKPEERCRED -DMYSQL_DYNAMIC_PLUGIN -Dauth_socket_EXPORTS -Wall -O2 -pipe   -Wall -O2 -g -DNDEBUG -DDBUG_OFF -fPIC -Iinclude -I/home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/include -I/home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/sql -Ipcre -I/home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/pcre -MMD -MT plugin/auth_socket/CMakeFiles/auth_socket.dir/auth_socket.c.o -MF plugin/auth_socket/CMakeFiles/auth_socket.dir/auth_socket.c.o.d -o plugin/auth_socket/CMakeFiles/auth_socket.dir/auth_socket.c.o   -c /home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/plugin/auth_socket/auth_socket.c
      FAILED: /usr/bin/cc  -DHAVE_CONFIG_H -DHAVE_SOCKPEERCRED -DMYSQL_DYNAMIC_PLUGIN -Dauth_socket_EXPORTS -Wall -O2 -pipe   -Wall -O2 -g -DNDEBUG -DDBUG_OFF -fPIC -Iinclude -I/home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/include -I/home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/sql -Ipcre -I/home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/pcre -MMD -MT plugin/auth_socket/CMakeFiles/auth_socket.dir/auth_socket.c.o -MF plugin/auth_socket/CMakeFiles/auth_socket.dir/auth_socket.c.o.d -o plugin/auth_socket/CMakeFiles/auth_socket.dir/auth_socket.c.o   -c /home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/plugin/auth_socket/auth_socket.c
      /home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/plugin/auth_socket/auth_socket.c: In function 'socket_auth':
      /home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/plugin/auth_socket/auth_socket.c:67: error: storage size of 'cred' isn't known
      /home/ports/pobj/mariadb-10.0.14/mariadb-10.0.14/plugin/auth_socket/auth_socket.c:67: warning: unused variable 'cred'
      ninja: build stopped: subcommand failed.

      Attachments

        Issue Links

          Activity

            I presume it's a result of changes made for MDEV-6577.

            elenst Elena Stepanova added a comment - I presume it's a result of changes made for MDEV-6577 .
            brad0 Brad Smith added a comment -

            Looking at the proposed diff in that ticket there is a good chance it does have something to do with the change there.

            brad0 Brad Smith added a comment - Looking at the proposed diff in that ticket there is a good chance it does have something to do with the change there.
            brad0 Brad Smith added a comment - - edited

            Yes, looked at that diff and noticed the typo..

            --- plugin/auth_socket/auth_socket.c.orig       Sat Sep 27 23:28:24 2014
            +++ plugin/auth_socket/auth_socket.c    Sat Sep 27 23:28:38 2014
            @@ -37,7 +37,7 @@
             #elif defined HAVE_SOCKPEERCRED
             #define level SOL_SOCKET
            -#define ucred socketpeercred
            +#define ucred sockpeercred
             
             #elif defined HAVE_XUCRED
             #include <sys/un.h>

            brad0 Brad Smith added a comment - - edited Yes, looked at that diff and noticed the typo.. --- plugin/auth_socket/auth_socket.c.orig Sat Sep 27 23:28:24 2014 +++ plugin/auth_socket/auth_socket.c Sat Sep 27 23:28:38 2014 @@ -37,7 +37,7 @@ #elif defined HAVE_SOCKPEERCRED #define level SOL_SOCKET -#define ucred socketpeercred +#define ucred sockpeercred   #elif defined HAVE_XUCRED #include <sys/un.h>

            Sorry for this. We have FreeBSD builders, but no OpenBSD so far

            Does the plugin work with that patch of yours?

            serg Sergei Golubchik added a comment - Sorry for this. We have FreeBSD builders, but no OpenBSD so far Does the plugin work with that patch of yours?
            brad0 Brad Smith added a comment -

            Yes, with the patch the code now compiles again as it did with 10.0.13.

            brad0 Brad Smith added a comment - Yes, with the patch the code now compiles again as it did with 10.0.13.

            People

              serg Sergei Golubchik
              brad0 Brad Smith
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.