Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-6536

make --bind=hostname to listen on both IPv6 and IPv4 addresses

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL)
    • 10.6.0
    • Server
    • None

    Description

      This is a spin-off from MDEV-4379. Quoting from there

      If a mariadb is configured to bind to a hostname, it should be possible for it to bind to both the ipv4 and ipv6 addresses defined for that hostname if the host is set up that way. This is the standard behavior with server software (openldap, postfix, apache, etc). Most also include options to force binding only to a specific ip protocol if desired. This is helpful for dual stack systems where it may be desired to have a server bind to both the ipv4 and ipv6 addresses for serving clients.

      Attachments

        Issue Links

          Activity

            brad0 Brad Smith added a comment -

            The lack of support for multiple sockets is what breaks dual-stack support on OpenBSD.

            brad0 Brad Smith added a comment - The lack of support for multiple sockets is what breaks dual-stack support on OpenBSD.
            danblack Daniel Black added a comment -

            MDEV-5536 also needs to expand the number of listening interface descriptors.

            danblack Daniel Black added a comment - MDEV-5536 also needs to expand the number of listening interface descriptors.
            brad0 Brad Smith added a comment -

            Still looking forward to this. We're up from 10.0 to 10.4, but IPv6 support is still broken without this.

            brad0 Brad Smith added a comment - Still looking forward to this. We're up from 10.0 to 10.4, but IPv6 support is still broken without this.

            wlad, could you please review this PR too? At least the handle_connections_win.cc part

            serg Sergei Golubchik added a comment - wlad , could you please review this PR too? At least the handle_connections_win.cc part
            wlad Vladislav Vaintroub added a comment - - edited

            I request a change around WaitForMultipleObjects(), in the very unlikely case wait_events.size() exceeds MAXIMUM_WAIT_OBJECTS=64. This would require at least 40 IP addresses for a name, and I'm not sure how it is possible, but the check must be there. Looks OK otherwise.

            wlad Vladislav Vaintroub added a comment - - edited I request a change around WaitForMultipleObjects(), in the very unlikely case wait_events.size() exceeds MAXIMUM_WAIT_OBJECTS=64. This would require at least 40 IP addresses for a name, and I'm not sure how it is possible, but the check must be there. Looks OK otherwise.
            danblack Daniel Black added a comment -

            All merged. Feels good to finally close of 6.5 year old bugs.

            Thanks rinat.ibragimov for the code. It is helping my MDEV-5536 significantly.

            danblack Daniel Black added a comment - All merged. Feels good to finally close of 6.5 year old bugs. Thanks rinat.ibragimov for the code. It is helping my MDEV-5536 significantly.

            People

              danblack Daniel Black
              serg Sergei Golubchik
              Votes:
              6 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.