Details
-
Bug
-
Status: Closed (View Workflow)
-
Trivial
-
Resolution: Fixed
-
5.5.37, 10.0.10
-
None
Description
As part of Debian quality assurance infrastructure the program called Lintian does hundreds of checks to incoming source packages (and later also binary packages).
Example: http://mentors.debian.net/package/mariadb-10.0
To fix spelling errors and executable bit errors in 5.5 tree and trunk I've created patches and opened the following merge requests:
https://code.launchpad.net/~otto/maria/maria-fix-spelling-trunk/+merge/216534
https://code.launchpad.net/~otto/maria/maria-fix-spelling-5.5/+merge/216537
Attachments
Activity
I tried to follow the instructions at https://mariadb.com/kb/en/contributing-code/ to my best, and thus opened a merge request on Launchpad.net. I was expecting that you would merge that request and then Launchpad would automatically update the status of the request and link the revision ID so that anybody can see when and where the fix branch was merged.
Apparently Launchpad does not do this automatically, so could you please fill in manually the field "Merged at revision", or how is this supposed to work?
I tried to track it myself e.g. viewing the history https://bazaar.launchpad.net/~maria-captains/maria/trunk/changes?filter_file_id=sp1f-mysql_com.h-19700101030959-a255cet4ojn7jbd4gb4wadueimhj57r7 but there are no revisions for that file this year, so I was wondering. Did I perhaps do something wrong when I filed the merge request?
You did everything correctly. It's just that this time I've took your changes as a patch, not merging them as a revision from your bzr tree. It was in the revno:4210 and only in 10.0 tree (I was, actually, sure I did it in 5.5, but apparently it went in 10.0 only).
Note that the Launchpad merge requests for 5.5. and trunk are slightly different. The trunk patch I assume should be applicable for both trunk and 10.0 branch.
For 5.5.38 the executable bit Lintian warnings are still there, so I assume my bzr patch wasn't properly applied or bzr does not handle file attributes correctly.
Listing at: http://lintian.debian.org/maintainer/pkg-mysql-maint@lists.alioth.debian.org.html#mariadb-5.5
[Package mariadb-test-5.5]
|
W executable-not-elf-or-script
|
usr/share/mysql/mysql-test/collections/default.weekly
|
usr/share/mysql/mysql-test/include/world.inc
|
usr/share/mysql/mysql-test/include/world_schema.inc
|
W script-not-executable
|
usr/share/mysql/mysql-test/std_data/checkDBI_DBD-mysql.pl
|
usr/share/mysql/mysql-test/suite/rpl/extension/checksum.pl
|
usr/share/mysql/mysql-test/t/long_tmpdir-master.sh
|
usr/share/mysql/mysql-test/t/lowercase_mixed_tmpdir-master.sh
|
This time I made a new attempt by making a git pull request on the new MariaDB Github tree.
The merge requests in Launchpad still shows status 'pending', wonder why..?