Details
-
Task
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.2.2-3, 10.2.2-2, 10.2.2-4
Description
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts).
This can be ported from 5.7
Looked at the MySQL 5.7 implementation. Too complex and too many not needed changed and moving of things to different files that make it very hard to follow code changes over time.
Will do this with new code, but will take test cases from MySQL 5.7
New functionality:
- "Any" amount of same events
- New syntax with
{ FOLLOWS | PRECEDES } trigger_name
CREATE [OR REPLACE]
[DEFINER = { user | CURRENT_USER }]
TRIGGER [IF NOT EXISTS] trigger_name trigger_time trigger_event
ON tbl_name FOR EACH ROW
[{ FOLLOWS | PRECEDES }other_trigger_name ]
trigger_stmt
Attachments
Issue Links
- is part of
-
MDEV-10137 Providing compatibility to other databases
-
- Open
-
- relates to
-
MDEV-10915 Multiple triggers are not counted in Executed_triggers status variable
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description | this can be ported form 5.7 |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts). This can be ported form 5.7 |
| Description |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts). This can be ported form 5.7 |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts). This can be ported from 5.7 |
| Assignee | Sergei Golubchik [ serg ] |
| Priority | Critical [ 2 ] | Major [ 3 ] |
| Fix Version/s | 10.1.1 [ 16100 ] | |
| Fix Version/s | 10.1.0 [ 12200 ] |
| Workflow | defaullt [ 38928 ] | MariaDB v2 [ 42494 ] |
| Workflow | MariaDB v2 [ 42494 ] | MariaDB v3 [ 61457 ] |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 10.1 [ 16100 ] |
| Fix Version/s | 10.2 [ 14601 ] |
| Link | This issue is part of MDEV-10137 [ MDEV-10137 ] |
| Labels | Compatibility |
| Sprint | 10.2.2-2 [ 92 ] |
| Rank | Ranked lower |
| Sprint | 10.2.2-2 [ 92 ] | 10.2.2-3, 10.2.2-2 [ 83, 92 ] |
| Sprint | 10.2.2-3, 10.2.2-2 [ 83, 92 ] | 10.2.2-3, 10.2.2-2, 10.2.2-4 [ 83, 92, 96 ] |
| Assignee | Sergei Golubchik [ serg ] | Michael Widenius [ monty ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Description |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts). This can be ported from 5.7 |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts).
This can be ported from 5.7 |
| Description |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts).
This can be ported from 5.7 |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts).
This can be ported from 5.7 Looked at the MySQL 5.7 implementation. Too complex and too many not needed changed and moving of things to different files that make it very hard to follow code changes over time. Will do this with new code, but will take test cases from MySQL 5.7 |
| Epic Link | MDEV-10872 [ 58182 ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
As it's completely optional to add a trigger for table, I don't see any reason to disable this.
We already have way too many startup options for MariaDB.
If one doesn't think a person is capable of using TRIGGER's, then one shouldn't give him the TRIGGER privilege.
| Description |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts).
This can be ported from 5.7 Looked at the MySQL 5.7 implementation. Too complex and too many not needed changed and moving of things to different files that make it very hard to follow code changes over time. Will do this with new code, but will take test cases from MySQL 5.7 |
Many triggers for the same event per table (e.g. many BEFORE DELETE triggerts).
This can be ported from 5.7 Looked at the MySQL 5.7 implementation. Too complex and too many not needed changed and moving of things to different files that make it very hard to follow code changes over time. Will do this with new code, but will take test cases from MySQL 5.7 New functionality: - "Any" amount of same events - New syntax with { FOLLOWS | PRECEDES } trigger_name CREATE [OR REPLACE] [DEFINER = { user | CURRENT_USER }] TRIGGER [IF NOT EXISTS] trigger_name trigger_time trigger_event ON tbl_name FOR EACH ROW [{ FOLLOWS | PRECEDES } other_trigger_name ] trigger_stmt |
Almost every feature can be limited in some way, the strangest example is sql_safe_updates.
But I realized that my proposal would add an incompatibility with MySQL, so it isn't a good idea.
| Link |
This issue relates to |
| Link |
This issue relates to |
Another reason for not adding an option for this is that multiple triggers per table is standard ANSI SQL feature.
Optionally disabling all features in SQL that may be problematic for some users is task independent of this one. For example, I think a lot of people would find it useful if DROP TABLE was disabled after they have dropped an important table 
| Link |
This issue relates to |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Component/s | Triggers [ 10109 ] | |
| Fix Version/s | 10.2.3 [ 22115 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10002 ] | Closed [ 6 ] |
| Link |
This issue relates to |
| Labels | Compatibility | Compatibility NRE-307517 |
| Labels | Compatibility NRE-307517 | Approved Compatibility NRE-307517 |
| NRE Projects | NRE-307517 |
| Labels | Approved Compatibility NRE-307517 | Approved Compatibility |
| NRE Approved | Yes [ 10304 ] |
| Labels | Approved Compatibility | Compatibility |
| Workflow | MariaDB v3 [ 61457 ] | MariaDB v4 [ 132321 ] |
Can this be disabled? Multiple triggers of the same type can be useful, but can also be chaotic and hard to debug...