Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5613

m_string.h exports generic function names without a namespace prefix, like str2int

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5.35
    • 5.5.36
    • None
    • None

    Description

      MariaDB's m_string.h exports generic function names without a namespace prefix, like str2int, which leads to collisions with other project's internal functions. See for example the Gentoo/Linux bugreport for a problem with GLPK.

      See Also: https://bugs.gentoo.org/show_bug.cgi?id=420095

      Attachments

        Activity

          I also reported this issue against GLPK: http://lists.gnu.org/archive/html/bug-glpk/2014-02/msg00001.html

          Andrew Makhorin correctly points out that MariaDB "should keep the namespace clean".

          devurandom Dennis Schridde added a comment - I also reported this issue against GLPK: http://lists.gnu.org/archive/html/bug-glpk/2014-02/msg00001.html Andrew Makhorin correctly points out that MariaDB "should keep the namespace clean".

          This happens, because my_sys.h includes my_valgrind.h, which includes m_string.h.

          Actually, an application isn't supposed to include my_sys.h, but m_string.h is particularly bad (or, should I say good? ) in polluting namespaces, so it's better to avoid it.

          I suppose we can easily fix this by not including m_string.h in my_valgrdind.h

          serg Sergei Golubchik added a comment - This happens, because my_sys.h includes my_valgrind.h , which includes m_string.h . Actually, an application isn't supposed to include my_sys.h , but m_string.h is particularly bad (or, should I say good? ) in polluting namespaces, so it's better to avoid it. I suppose we can easily fix this by not including m_string.h in my_valgrdind.h

          People

            serg Sergei Golubchik
            devurandom Dennis Schridde
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.