Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5228

Incorrect message test on a failed attempt to revoke grants from a role

Details

    Description

      The message incorrectly identifies the entity as a user, while it is a role:

      MariaDB [test]> create role foo;
      Query OK, 0 rows affected (0.01 sec)
       
      MariaDB [test]> revoke all on bar.* from foo;
      ERROR 1141 (42000): There is no such grant defined for user 'foo' on host ''

      Since other errors seem to be able to distinguish between a user and a role, it might make sense fix this one too.

      Attachments

        Issue Links

          Activity

            elenst Elena Stepanova created issue -
            elenst Elena Stepanova made changes -
            Field Original Value New Value
            elenst Elena Stepanova made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.7 [ 14100 ]
            Fix Version/s 10.0.6 [ 13202 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.8 [ 14200 ]
            Fix Version/s 10.0.7 [ 14100 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.9 [ 14400 ]
            Fix Version/s 10.0.8 [ 14200 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.10 [ 14500 ]
            Fix Version/s 10.0.9 [ 14400 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.11 [ 15200 ]
            Fix Version/s 10.0.10 [ 14500 ]
            elenst Elena Stepanova made changes -
            Affects Version/s 10.0.10 [ 14500 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.12 [ 15201 ]
            Fix Version/s 10.0.11 [ 15200 ]
            serg Sergei Golubchik made changes -
            Workflow defaullt [ 29534 ] MariaDB v2 [ 44615 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0.13 [ 16000 ]
            Fix Version/s 10.0.12 [ 15201 ]
            cvicentiu Vicențiu Ciorbaru made changes -
            Assignee Sergei Golubchik [ serg ] Vicentiu Ciorbaru [ cvicentiu ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 44615 ] MariaDB v3 [ 63969 ]
            ip1981 Igor Pashev added a comment - - edited

            REVOKE ALL, GRANT OPTION FROM <role>; also fails if the <role> has no privileges granted.

            ip1981 Igor Pashev added a comment - - edited REVOKE ALL, GRANT OPTION FROM <role>; also fails if the <role> has no privileges granted.
            ip1981 Igor Pashev added a comment -

            It's even more complicated:

            MariaDB [mysql]> create role role1;
            Query OK, 0 rows affected (0.01 sec)
             
            MariaDB [mysql]> grant select on mysql.user to role1;
            Query OK, 0 rows affected (0.01 sec)
             
            MariaDB [mysql]> create role role2;
            Query OK, 0 rows affected (0.00 sec)
             
            MariaDB [mysql]> grant role1 to role2;
            Query OK, 0 rows affected (0.00 sec)
             
            MariaDB [mysql]> revoke all, grant option from role2;
            ERROR 1147 (42000): There is no such grant defined for user 'role2' on host '' on table 'user'
            Error (Code 1147): There is no such grant defined for user 'role2' on host '' on table 'user'
            Error (Code 1269): Can't revoke all privileges for one or more of the requested users
            MariaDB [mysql]> show grants for role2;
            +-------------------------------+
            | Grants for role2              |
            +-------------------------------+
            | GRANT USAGE ON *.* TO 'role2' |
            +-------------------------------+
            
            

            ip1981 Igor Pashev added a comment - It's even more complicated: MariaDB [mysql]> create role role1; Query OK, 0 rows affected (0.01 sec)   MariaDB [mysql]> grant select on mysql.user to role1; Query OK, 0 rows affected (0.01 sec)   MariaDB [mysql]> create role role2; Query OK, 0 rows affected (0.00 sec)   MariaDB [mysql]> grant role1 to role2; Query OK, 0 rows affected (0.00 sec)   MariaDB [mysql]> revoke all, grant option from role2; ERROR 1147 (42000): There is no such grant defined for user 'role2' on host '' on table 'user' Error (Code 1147): There is no such grant defined for user 'role2' on host '' on table 'user' Error (Code 1269): Can't revoke all privileges for one or more of the requested users MariaDB [mysql]> show grants for role2; +-------------------------------+ | Grants for role2 | +-------------------------------+ | GRANT USAGE ON *.* TO 'role2' | +-------------------------------+
            cvicentiu Vicențiu Ciorbaru made changes -
            Labels beginner-friendly
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 63969 ] MariaDB v4 [ 139555 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0 [ 16000 ]
            elenst Elena Stepanova made changes -
            Component/s Authentication and Privilege System [ 13101 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.7 [ 24805 ]
            Fix Version/s 10.8 [ 26121 ]
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.10 [ 27530 ]
            Affects Version/s 10.3 [ 22126 ]
            Affects Version/s 10.4 [ 22408 ]
            Affects Version/s 10.5 [ 23123 ]
            Affects Version/s 10.6 [ 24028 ]
            Affects Version/s 10.7 [ 24805 ]
            Affects Version/s 10.8 [ 26121 ]
            Affects Version/s 10.9 [ 26905 ]
            Affects Version/s 10.10 [ 27530 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.7 [ 24805 ]
            kevin_cheng kevin cheng made changes -
            Comment [ Hello, I have been able to reproduce the problem on version 10.4, and I am eager to solve it. Would it be possible for me to take on this task? Also, which branch should I use as the base branch? Thank you for your help. ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.3 [ 22126 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.8 [ 26121 ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.9 [ 26905 ]
            Fix Version/s 10.10 [ 27530 ]

            Fix for the issue submitted in https://github.com/MariaDB/server/pull/3114

            nickothieno Nicholas Othieno added a comment - Fix for the issue submitted in https://github.com/MariaDB/server/pull/3114
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.4 [ 22408 ]
            svoj Sergey Vojtovich made changes -
            Labels beginner-friendly beginner-friendly contribution
            vlad.radu Vlad Radu made changes -
            Labels beginner-friendly contribution beginner-friendly contribution foundation

            People

              cvicentiu Vicențiu Ciorbaru
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.