Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5205

MariaDB does not start if more than 128 cpu's are available

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5.33a
    • 5.5.34
    • None
    • None
    • IBM systemx with 8 cpus with 10 cores with 2 threads = 160 available cpu's

    Description

      MAX_THREAD_GROUPS 128 setting prevents MariaDB from starting. No configuration is read at the time this check is made. Solution: make allocating the structure dynamic, make default to be always less than MAX_THREAD_GROUPS, or make MAX_THREAD_GROUPS bigger.

      ./sql/threadpool_unix.cc:static thread_group_t all_groups[MAX_THREAD_GROUPS];
      ./sql/threadpool.h:#define MAX_THREAD_GROUPS 128
      ./sql/sys_vars.cc: VALID_RANGE(1, MAX_THREAD_GROUPS), DEFAULT(my_getncpus()), BLOCK_SIZE(1),

      Server does not start if my_getncpus() > MAX_THREAD_GROUPS and there is no configuration option around that.

      Attachments

        Issue Links

          Activity

            hyvatti Jaakko Hyvätti created issue -
            svoj Sergey Vojtovich made changes -
            Field Original Value New Value
            Assignee Sergey Vojtovich [ svoj ]
            serg Sergei Golubchik made changes -
            Fix Version/s 5.5.34 [ 13700 ]
            svoj Sergey Vojtovich made changes -
            Assignee Sergey Vojtovich [ svoj ] Sergei Golubchik [ serg ]

            Sergei, please review fix for this bug. It makes all_groups dynamic, though I can't judge if there is much sense setting it to high values even on computers with huge amount of cores.

            svoj Sergey Vojtovich added a comment - Sergei, please review fix for this bug. It makes all_groups dynamic, though I can't judge if there is much sense setting it to high values even on computers with huge amount of cores.

            look ok, see the comment in the email

            serg Sergei Golubchik added a comment - look ok, see the comment in the email
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Sergey Vojtovich [ svoj ]

            Fixed in 5.5.34, revision-id: svoj@mariadb.org-20131105051859-pytrunre7wtyfcls

            svoj Sergey Vojtovich added a comment - Fixed in 5.5.34, revision-id: svoj@mariadb.org-20131105051859-pytrunre7wtyfcls
            svoj Sergey Vojtovich made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow defaullt [ 29508 ] MariaDB v2 [ 44414 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 44414 ] MariaDB v3 [ 63762 ]
            wlad Vladislav Vaintroub made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 63762 ] MariaDB v4 [ 147178 ]

            People

              svoj Sergey Vojtovich
              hyvatti Jaakko Hyvätti
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.