Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22578

thread_pool_info crashes with clang6, using SSE instructions on unaligned memory

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.5
    • 10.5.4
    • Server
    • None

    Attachments

      Issue Links

        Activity

          69077dea25f6e7cab4ff8927e4429ad62af9de49

          wlad Vladislav Vaintroub added a comment - 69077dea25f6e7cab4ff8927e4429ad62af9de49

          wlad, I think that a better fix would have been to use aligned_malloc(), which is guaranteed to be available already in MariaDB Server 10.2. Just move the function declaration from InnoDB to somewhere where it is globally usable.

          marko Marko Mäkelä added a comment - wlad , I think that a better fix would have been to use aligned_malloc() , which is guaranteed to be available already in MariaDB Server 10.2. Just move the function declaration from InnoDB to somewhere where it is globally usable.

          marko, I don't disagree that it would be a slightly better fix, yet I'm wondering how much effort would be needed to make that aligned_malloc also aligned with the whole mysys stuff, like safemalloc and the memory accounting, and the PSI in 10.5 . Probably it would also need to be exported via server services. If I think about all that vs 2 lines fix, I choose 2 lines.
          That does not mean, my_aligned_malloc should not be done, but not in scope of that fix.

          wlad Vladislav Vaintroub added a comment - marko , I don't disagree that it would be a slightly better fix, yet I'm wondering how much effort would be needed to make that aligned_malloc also aligned with the whole mysys stuff, like safemalloc and the memory accounting, and the PSI in 10.5 . Probably it would also need to be exported via server services. If I think about all that vs 2 lines fix, I choose 2 lines. That does not mean, my_aligned_malloc should not be done, but not in scope of that fix.

          People

            wlad Vladislav Vaintroub
            wlad Vladislav Vaintroub
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.