XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.5.36, 10.0.9
    • Fix Version/s: 10.0.10
    • Component/s: None
    • Labels:
      None
    • Environment:
      pc x86-64 Debian testing

      Description

      Hello,

      Cppcheck (a free C++ static analyzer) reported this on trunk bzr sources retrieved yesterday:

      [extra/jemalloc/src/arena.c:2268] -> [extra/jemalloc/src/arena.c:2268]: (style) Same expression on both sides of '&&'.
      [sql/filesort_utils.h:98] -> [sql/filesort_utils.h:98]: (style) Same expression on both sides of '=='.
      [sql-common/client_authentication.cc:85] -> [sql-common/client_authentication.cc:85]: (style) Same expression on both sides of '&&'.

      [extra/yassl/src/yassl_int.cpp:1103]: (performance) Prefer prefix ++/-- operators for non-primitive types.
      [libmysqld/examples/builder-sample/emb_samples.cpp:199]: (performance) Prefer prefix ++/-- operators for non-primitive types.
      [sql/item_cmpfunc.cc:6025]: (performance) Prefer prefix ++/-- operators for non-primitive types.
      [sql/item_subselect.cc:1886]: (performance) Prefer prefix ++/-- operators for non-primitive types.
      [sql/opt_subselect.cc:3699]: (performance) Prefer prefix ++/-- operators for non-primitive types.

      [extra/jemalloc/test/thread_arena.c:80]: (error) Memory leak: p
      [extra/yassl/examples/echoserver/echoserver.cpp:166]: (error) Resource leak: fout
      [extra/yassl/src/ssl.cpp:794]: (error) Resource leak: dir
      [sql/set_var.h:213]: (style) Class 'set_var' is unsafe, 'set_var::value' can leak by wrong usage.
      [sql/sql_select.h:1594]: (style) Class 'store_key' is unsafe, 'store_key::to_field' can leak by wrong usage.
      [mysys/ma_dyncol.c:1650]: (error) Memory leak: columns_order
      [mysys/ma_dyncol.c:4036]: (error) Memory leak: str
      [pcre/pcregrep.c:468]: (error) Memory leak: p
      [sql/mysql_install_db.cc:662]: (error) Resource leak: in
      [sql/sp.cc:2246]: (error) Memory leak: creation_ctx

      [sql/handler.h:606]: (error) Buffer is accessed out of bounds: data

      [mysys/ma_dyncol.c:3962] -> [mysys/ma_dyncol.c:3958]: (style) Duplicate conditions in 'if' and related 'else if'.

      [cmd-line-utils/readline/bind.c:2087]: (style) Array index 'j' is used before limits check.

      [sql/handler.h:606]: (error) Buffer is accessed out of bounds: data

      and this kind:

      [sql/sp_head.cc:596]: (warning) Ineffective call of function 'empty()'. Did you intend to call 'clear()' instead?

      (I attached a file)

      I let cppcheck run only about 600 files on a little less than 3000 because it's very long. If you're interested in these reports, I'll try a full run.

      Julien

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              serg Sergei Golubchik
              Reporter:
              serval2412 Julien Nabet
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: