[MDEV-5120] Test suite test maria-no-logging fails - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 5.5.33a, 10.0.7, 10.0.14
Fix Version/s: 5.5.40, 10.0.15
Component/s: Storage Engine - Aria
Labels:
- Aria
Environment:
Slackware Linux 14.1 + kernel 3.12.6

Description

cd /usr/mysql-test; ./mtr maria-no-logging

(as root) gives me an error report as below. The odd-looking file name starting with a ";" can vary between runs. I am keeping the mysql-test directory, so please let me know if you'd like anything else from it.

CURRENT_TEST: maria.maria-no-logging

--- /usr/mysql-test/suite/maria/maria-no-logging.result 2013-09-20 08:34:23.000000000 +1000

+++ /usr/mysql-test/suite/maria/maria-no-logging.reject 2013-10-10 12:49:38.000000000 +1100

@@ -20,18 +20,18 @@

 ) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 TRANSACTIONAL=1

 show engine aria logs;

 Type   Name    Status

-Aria   Size        16384 aria_log.00000001     unknown

+Aria   Size        16384 ; ?r  unknown

 insert into t1 values('a');

 insert into t1 select * from t2;

 show engine aria logs;

 Type   Name    Status

-Aria   Size        24576 aria_log.00000001     unknown

+Aria   Size        24576 ; ?r  unknown

 * shut down mysqld, removed logs, restarted it

 truncate table t1;

 insert into t1 select * from t2;

 show engine aria logs;

 Type   Name    Status

-Aria   Size        16384 aria_log.00000001     unknown

+Aria   Size        16384 ; ?r  unknown

 drop table t1;

 * shut down mysqld, removed logs, restarted it

 create table t1 (a varchar(100)) engine=aria transactional=1;

@@ -41,11 +41,11 @@

 Note   1050    Table 't1' already exists

 show engine aria logs;

 Type   Name    Status

-Aria   Size        16384 aria_log.00000001     unknown

+Aria   Size        16384 ; ?r  unknown

 * shut down mysqld, removed logs, restarted it

 drop table t1;

 create table t1 engine=aria transactional=1 select * from t2;

 show engine aria logs;

 Type   Name    Status

-Aria   Size        16384 aria_log.00000001     unknown

+Aria   Size        16384 ; ?r  unknown

 drop database mysqltest;

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

lslRmaria-no-logging.txt
7 kB
2013-10-11 07:57
mariadb_slackbuild.tar.gz
12 kB
2013-10-16 01:55

Issue Links

is duplicated by

MDEV-5121 Test suite test maria-purge fails

Closed

relates to

MDEV-6862 "#error <my_config.h>" and third-party libraries

Closed

Activity

Ascending order - Click to sort in descending order

Duncan Roe created issue - 2013-10-10 05:07

Duncan Roe made changes - 2013-10-10 05:10

Field	Original Value	New Value
Description	cd /usr/mysql-test; ./mtr maria-no-logging (as root) gives me an error report as below. The odd-looking file name starting with a "?" can vary between runs. I am keeping the mysql-test directory, so please let me know if you'd like anything else from it. CURRENT_TEST: maria.maria-no-logging --- /usr/mysql-test/suite/maria/maria-no-logging.result 2013-09-20 08:34:23.000000000 +1000 +++ /usr/mysql-test/suite/maria/maria-no-logging.reject 2013-10-10 12:49:38.000000000 +1100 @@ -20,18 +20,18 @@ ) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 TRANSACTIONAL=1 show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ?r unknown insert into t1 values('a'); insert into t1 select * from t2; show engine aria logs; Type Name Status -Aria Size 24576 aria_log.00000001 unknown +Aria Size 24576 ; ?r unknown * shut down mysqld, removed logs, restarted it truncate table t1; insert into t1 select * from t2; show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ?r unknown drop table t1; * shut down mysqld, removed logs, restarted it create table t1 (a varchar(100)) engine=aria transactional=1; @@ -41,11 +41,11 @@ Note 1050 Table 't1' already exists show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ?r unknown * shut down mysqld, removed logs, restarted it drop table t1; create table t1 engine=aria transactional=1 select * from t2; show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ?r unknown drop database mysqltest;	cd /usr/mysql-test; ./mtr maria-no-logging (as root) gives me an error report as below. The odd-looking file name starting with a ";" can vary between runs. I am keeping the mysql-test directory, so please let me know if you'd like anything else from it. CURRENT_TEST: maria.maria-no-logging --- /usr/mysql-test/suite/maria/maria-no-logging.result 2013-09-20 08:34:23.000000000 +1000 +++ /usr/mysql-test/suite/maria/maria-no-logging.reject 2013-10-10 12:49:38.000000000 +1100 @@ -20,18 +20,18 @@ ) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 TRANSACTIONAL=1 show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ?r unknown insert into t1 values('a'); insert into t1 select * from t2; show engine aria logs; Type Name Status -Aria Size 24576 aria_log.00000001 unknown +Aria Size 24576 ; ?r unknown * shut down mysqld, removed logs, restarted it truncate table t1; insert into t1 select * from t2; show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ?r unknown drop table t1; * shut down mysqld, removed logs, restarted it create table t1 (a varchar(100)) engine=aria transactional=1; @@ -41,11 +41,11 @@ Note 1050 Table 't1' already exists show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ?r unknown * shut down mysqld, removed logs, restarted it drop table t1; create table t1 engine=aria transactional=1 select * from t2; show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ?r unknown drop database mysqltest;

Duncan Roe made changes - 2013-10-10 07:13

Link

This issue relates to ~~MDEV-5121~~ [ ~~MDEV-5121~~ ]

Elena Stepanova made changes - 2013-10-10 07:28

Assignee

Elena Stepanova [ elenst ]

Elena Stepanova made changes - 2013-10-10 09:55

Description

cd /usr/mysql-test; ./mtr maria-no-logging
(as root) gives me an error report as below. The odd-looking file name starting with a ";" can vary between runs. I am keeping the mysql-test directory, so please let me know if you'd like anything else from it.

CURRENT_TEST: maria.maria-no-logging
--- /usr/mysql-test/suite/maria/maria-no-logging.result 2013-09-20 08:34:23.000000000 +1000
+++ /usr/mysql-test/suite/maria/maria-no-logging.reject 2013-10-10 12:49:38.000000000 +1100
@@ -20,18 +20,18 @@
) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 TRANSACTIONAL=1
show engine aria logs;
Type Name Status
-Aria Size 16384 aria_log.00000001 unknown
+Aria Size 16384 ; ?r unknown
insert into t1 values('a');
insert into t1 select * from t2;
show engine aria logs;
Type Name Status
-Aria Size 24576 aria_log.00000001 unknown
+Aria Size 24576 ; ?r unknown
* shut down mysqld, removed logs, restarted it
truncate table t1;
insert into t1 select * from t2;
show engine aria logs;
Type Name Status
-Aria Size 16384 aria_log.00000001 unknown
+Aria Size 16384 ; ?r unknown
drop table t1;
* shut down mysqld, removed logs, restarted it
create table t1 (a varchar(100)) engine=aria transactional=1;
@@ -41,11 +41,11 @@
Note 1050 Table 't1' already exists
show engine aria logs;
Type Name Status
-Aria Size 16384 aria_log.00000001 unknown
+Aria Size 16384 ; ?r unknown
* shut down mysqld, removed logs, restarted it
drop table t1;
create table t1 engine=aria transactional=1 select * from t2;
show engine aria logs;
Type Name Status
-Aria Size 16384 aria_log.00000001 unknown
+Aria Size 16384 ; ?r unknown
drop database mysqltest;

{noformat}
cd /usr/mysql-test; ./mtr maria-no-logging
{noformat}
(as root) gives me an error report as below. The odd-looking file name starting with a ";" can vary between runs. I am keeping the mysql-test directory, so please let me know if you'd like anything else from it.

{noformat}
CURRENT_TEST: maria.maria-no-logging
--- /usr/mysql-test/suite/maria/maria-no-logging.result 2013-09-20 08:34:23.000000000 +1000
+++ /usr/mysql-test/suite/maria/maria-no-logging.reject 2013-10-10 12:49:38.000000000 +1100
@@ -20,18 +20,18 @@
) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 TRANSACTIONAL=1
show engine aria logs;
Type Name Status
-Aria Size 16384 aria_log.00000001 unknown
+Aria Size 16384 ; ?r unknown
insert into t1 values('a');
insert into t1 select * from t2;
show engine aria logs;
Type Name Status
-Aria Size 24576 aria_log.00000001 unknown
+Aria Size 24576 ; ?r unknown
* shut down mysqld, removed logs, restarted it
truncate table t1;
insert into t1 select * from t2;
show engine aria logs;
Type Name Status
-Aria Size 16384 aria_log.00000001 unknown
+Aria Size 16384 ; ?r unknown
drop table t1;
* shut down mysqld, removed logs, restarted it
create table t1 (a varchar(100)) engine=aria transactional=1;
@@ -41,11 +41,11 @@
Note 1050 Table 't1' already exists
show engine aria logs;
Type Name Status
-Aria Size 16384 aria_log.00000001 unknown
+Aria Size 16384 ; ?r unknown
* shut down mysqld, removed logs, restarted it
drop table t1;
create table t1 engine=aria transactional=1 select * from t2;
show engine aria logs;
Type Name Status
-Aria Size 16384 aria_log.00000001 unknown
+Aria Size 16384 ; ?r unknown
drop database mysqltest;
{noformat}

Elena Stepanova added a comment - 2013-10-10 10:05

Hi,

Could you please run
ls -l var/log/maria.maria-no-logging/mysqld.1/data/
from your mysql-test directory after you get the failure?
Thanks.

Elena Stepanova added a comment - 2013-10-10 10:05 Hi, Could you please run ls -l var/log/maria.maria-no-logging/mysqld.1/data/ from your mysql-test directory after you get the failure? Thanks.

Duncan Roe added a comment - 2013-10-11 07:43

Hi Elena,

15:41:17$ ls -l var/log/maria.maria-no-logging/mysqld.1/data/
total 36
~~rw-rw~~--- 1 root root 16384 Oct 10 12:49 aria_log.00000001
~~rw-rw~~--- 1 root root 52 Oct 10 12:49 aria_log_control
drwxr-xr-x 2 root root 4096 Oct 10 12:49 mtr
drwxr-xr-x 2 root root 4096 Oct 10 12:49 mysql
drwxr-xr-x 2 root root 4096 Oct 10 12:49 performance_schema
drwxr-xr-x 2 root root 4096 Oct 10 12:49 test
15:41:40$

Cheers ... Duncan.

Duncan Roe added a comment - 2013-10-11 07:43 Hi Elena, 15:41:17$ ls -l var/log/maria.maria-no-logging/mysqld.1/data/ total 36 rw-rw --- 1 root root 16384 Oct 10 12:49 aria_log.00000001 rw-rw --- 1 root root 52 Oct 10 12:49 aria_log_control drwxr-xr-x 2 root root 4096 Oct 10 12:49 mtr drwxr-xr-x 2 root root 4096 Oct 10 12:49 mysql drwxr-xr-x 2 root root 4096 Oct 10 12:49 performance_schema drwxr-xr-x 2 root root 4096 Oct 10 12:49 test 15:41:40$ Cheers ... Duncan.

Duncan Roe made changes - 2013-10-11 07:57

Attachment

lslRmaria-no-logging.txt [ 23808 ]

Duncan Roe added a comment - 2013-10-11 08:07

Hi again Elena,

I also added ls -lR as an attachment,

Cheers ... Duncan.

Duncan Roe added a comment - 2013-10-11 08:07 Hi again Elena, I also added ls -lR as an attachment, Cheers ... Duncan.

Sergei Golubchik made changes - 2013-10-15 06:21

Labels

MariaDB_5.5 tests

tests

Elena Stepanova added a comment - 2013-10-15 17:29

Hi Duncan,

How did you install the server? I'm wondering how mysql-test folder ended up under /usr/.
I tried to reproduce the problem on Slackware 14.0 with the standard MariaDB installation from a bintar, but didn't get the failure; and I do suspect that it has something to do with the location.

Elena Stepanova added a comment - 2013-10-15 17:29 Hi Duncan, How did you install the server? I'm wondering how mysql-test folder ended up under /usr/. I tried to reproduce the problem on Slackware 14.0 with the standard MariaDB installation from a bintar, but didn't get the failure; and I do suspect that it has something to do with the location.

Duncan Roe made changes - 2013-10-16 01:55

Attachment

mariadb_slackbuild.tar.gz [ 23907 ]

Duncan Roe added a comment - 2013-10-16 02:09

Hi Elena,

I built and installed mariadb as it will build and install in the next Slackware release (as far as I can tell). I've uploaded a tar.gz of a directory with build instructions and all necessary files except the source archive. This is the README:

To build mariadb for Slackware installation, first make a symbolic link to the source archive, e.g.

"ln -s /usr/gz/mariadb-10.0.4.tar.gz " It doesn't matter if archive is gz, xz or bz2.

You now have to run mariadb.SlackBuild as root - but this is your Slackware system, right? mariadb.SlackBuild is minimally altered from the script on the Slackware site (which only build xz archives) - you can inspect with rcsdiff.

You need to tell the build to install the test suite, and you probably want to give it a special build ID (the patches to fix 2 tests are new). I used:

KEEPTESTS=1 BUILD=1TSTEVT ./mariadb.SlackBuild

EVT is in the ID because I have installed libevent. This is not standard in Slackware 14.0 but appears to be slated for the next Slackware release (you can find the build directory at ftp.osuosl.org/pub/slackware/slackware-current/source/l/libevent).

The last item the build script displays should be "Slackware package /tmp/mariadb-10.0.4-i486-1TSTEVT.txz created"

To install:

installpkg /tmp/mariadb-10.0.4-i486-1TSTEVT.txz

On a standard system, this will probably create /etc/rc.mysqld.new, which replaces the existing script that starts mysqld. I have found that tests don't run if the server is started, so so don't start it yet. The test should now give you the same result as I get.

N.B. This is for 32-bit x86.

Duncan Roe added a comment - 2013-10-16 02:09 Hi Elena, I built and installed mariadb as it will build and install in the next Slackware release (as far as I can tell). I've uploaded a tar.gz of a directory with build instructions and all necessary files except the source archive. This is the README: To build mariadb for Slackware installation, first make a symbolic link to the source archive, e.g. "ln -s /usr/gz/mariadb-10.0.4.tar.gz " It doesn't matter if archive is gz, xz or bz2. You now have to run mariadb.SlackBuild as root - but this is your Slackware system, right? mariadb.SlackBuild is minimally altered from the script on the Slackware site (which only build xz archives) - you can inspect with rcsdiff. You need to tell the build to install the test suite, and you probably want to give it a special build ID (the patches to fix 2 tests are new). I used: KEEPTESTS=1 BUILD=1TSTEVT ./mariadb.SlackBuild EVT is in the ID because I have installed libevent. This is not standard in Slackware 14.0 but appears to be slated for the next Slackware release (you can find the build directory at ftp.osuosl.org/pub/slackware/slackware-current/source/l/libevent). The last item the build script displays should be "Slackware package /tmp/mariadb-10.0.4-i486-1TSTEVT.txz created" To install: installpkg /tmp/mariadb-10.0.4-i486-1TSTEVT.txz On a standard system, this will probably create /etc/rc.mysqld.new, which replaces the existing script that starts mysqld. I have found that tests don't run if the server is started, so so don't start it yet. The test should now give you the same result as I get. N.B. This is for 32-bit x86.

Duncan Roe made changes - 2014-01-02 02:08

Affects Version/s

10.0.7 [ 14100 ]

Duncan Roe added a comment - 2014-01-02 02:11

Tried again at 10.0.7 but still fails for me

Duncan Roe added a comment - 2014-01-02 02:11 Tried again at 10.0.7 but still fails for me

Duncan Roe made changes - 2014-01-02 07:17

Environment

Slackware Linux 14.0 + kernel 3.10.4

Slackware Linux 14.1 + kernel 3.12.6

Duncan Roe made changes - 2014-02-11 12:23

Affects Version/s

10.0.8 [ 14200 ]

Duncan Roe added a comment - 2014-02-11 12:24

Still fails at 10.0.8

Duncan Roe added a comment - 2014-02-11 12:24 Still fails at 10.0.8

Sergei Golubchik made changes - 2014-06-13 15:06

Workflow

defaullt [ 29246 ]

MariaDB v2 [ 45013 ]

Elena Stepanova added a comment - 2014-09-29 14:03

We got a report that the test started failing the same way on 32-bit Debian Sid, apparently after recent upgrades to Sid. 64-bit Sid doesn't seem to be affected.

It's reproducible with the current 10.0 tree.

I'm raising the priority because it is not just tests, it really affects the server, show engine aria logs produces the corrupted output. While it isn't clear whether it's a code bug or a system bug, I'm assigning to Monty since he volunteered to investigate.

Elena Stepanova added a comment - 2014-09-29 14:03 We got a report that the test started failing the same way on 32-bit Debian Sid, apparently after recent upgrades to Sid. 64-bit Sid doesn't seem to be affected. It's reproducible with the current 10.0 tree. I'm raising the priority because it is not just tests, it really affects the server, show engine aria logs produces the corrupted output. While it isn't clear whether it's a code bug or a system bug, I'm assigning to Monty since he volunteered to investigate.

Elena Stepanova made changes - 2014-09-29 14:03

Affects Version/s		10.0.14 [ 17101 ]
Affects Version/s	10.0.8 [ 14200 ]
Assignee	Elena Stepanova [ elenst ]	Michael Widenius [ monty ]
Labels	tests	Aria
Priority	Minor [ 4 ]	Major [ 3 ]

Elena Stepanova made changes - 2014-09-29 14:11

Link

This issue is duplicated by ~~MDEV-5121~~ [ ~~MDEV-5121~~ ]

Elena Stepanova made changes - 2014-09-29 14:12

Link

This issue relates to ~~MDEV-5121~~ [ ~~MDEV-5121~~ ]

Otto Kekäläinen added a comment - 2014-09-29 20:04

The failure looks very much alike what I've seen on Debian Sid after about Sept 20th in my i386 builds (not amd64): http://labs.seravo.fi/~otto/mariadb-repo/logs/maria.maria-no-logging/mariadb-10.0_10.0.14-1_sid-i386.build

maria.maria-no-logging                   [ fail ]

        Test ended at 2014-09-28 13:12:33

CURRENT_TEST: maria.maria-no-logging

--- /tmp/buildd/mariadb-10.0-10.0.14/mysql-test/suite/maria/maria-no-logging.result	2014-09-24 22:29:46.000000000 +0000

+++ /tmp/buildd/mariadb-10.0-10.0.14/mysql-test/suite/maria/maria-no-logging.reject	2014-09-28 13:12:32.980386165 +0000

@@ -20,18 +20,18 @@

 ) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 TRANSACTIONAL=1

 show engine aria logs;

 Type	Name	Status

-Aria	Size        16384 aria_log.00000001	unknown

+Aria	Size        16384 ; ???�	unknown

 insert into t1 values('a');

 insert into t1 select * from t2;

 show engine aria logs;

 Type	Name	Status

-Aria	Size        24576 aria_log.00000001	unknown

+Aria	Size        24576 ; ???�	unknown

 * shut down mysqld, removed logs, restarted it

 truncate table t1;

 insert into t1 select * from t2;

 show engine aria logs;

 Type	Name	Status

-Aria	Size        16384 aria_log.00000001	unknown

+Aria	Size        16384 ; W??�	unknown

 drop table t1;

 * shut down mysqld, removed logs, restarted it

 create table t1 (a varchar(100)) engine=aria transactional=1;

@@ -41,11 +41,11 @@

 Note	1050	Table 't1' already exists

 show engine aria logs;

 Type	Name	Status

-Aria	Size        16384 aria_log.00000001	unknown

+Aria	Size        16384 ; h??�	unknown

 * shut down mysqld, removed logs, restarted it

 drop table t1;

 create table t1 engine=aria transactional=1 select * from t2;

 show engine aria logs;

 Type	Name	Status

-Aria	Size        16384 aria_log.00000001	unknown

+Aria	Size        16384 ; ???�	unknown

 drop database mysqltest;

mysqltest: Result length mismatch

Otto Kekäläinen added a comment - 2014-09-29 20:04 The failure looks very much alike what I've seen on Debian Sid after about Sept 20th in my i386 builds (not amd64): http://labs.seravo.fi/~otto/mariadb-repo/logs/maria.maria-no-logging/mariadb-10.0_10.0.14-1_sid-i386.build maria.maria-no-logging [ fail ] Test ended at 2014-09-28 13:12:33 CURRENT_TEST: maria.maria-no-logging --- /tmp/buildd/mariadb-10.0-10.0.14/mysql-test/suite/maria/maria-no-logging.result 2014-09-24 22:29:46.000000000 +0000 +++ /tmp/buildd/mariadb-10.0-10.0.14/mysql-test/suite/maria/maria-no-logging.reject 2014-09-28 13:12:32.980386165 +0000 @@ -20,18 +20,18 @@ ) ENGINE=Aria DEFAULT CHARSET=latin1 PAGE_CHECKSUM=1 TRANSACTIONAL=1 show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ???� unknown insert into t1 values('a'); insert into t1 select * from t2; show engine aria logs; Type Name Status -Aria Size 24576 aria_log.00000001 unknown +Aria Size 24576 ; ???� unknown * shut down mysqld, removed logs, restarted it truncate table t1; insert into t1 select * from t2; show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; W??� unknown drop table t1; * shut down mysqld, removed logs, restarted it create table t1 (a varchar(100)) engine=aria transactional=1; @@ -41,11 +41,11 @@ Note 1050 Table 't1' already exists show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; h??� unknown * shut down mysqld, removed logs, restarted it drop table t1; create table t1 engine=aria transactional=1 select * from t2; show engine aria logs; Type Name Status -Aria Size 16384 aria_log.00000001 unknown +Aria Size 16384 ; ???� unknown drop database mysqltest; mysqltest: Result length mismatch

Michael Widenius added a comment - 2014-09-30 00:46 - edited

The problem is a in the stat structure at /usr/include/i386-linux-gnu/bits/stat.h

Depending on how you compile your program (with or without __USE_FILE_OFFSET64) the structure gets different sizes.

Here is an example:

#if defined __x86_64__ || !defined __USE_FILE_OFFSET64

    __off_t st_size;                    /* Size of file, in bytes.  */

#else

    __off64_t st_size;                  /* Size of file, in bytes.  */

#endif

The variable is either 4 or 8 bytes, depending on the value of __USE_FILE_OFFSET64,

In storage/maria/ha_maria.cc, we included files in a non standard order and struct stat got to be defined too small, which caused memory overruns.

I have now fixed so that we always include <my_global.h> first, which fixes this issue. I will push this into 10.0 tree shortly

However someone should fix so that 'struct stat' has always the same size, independent of how you compile it on x86.
On 64 bits it's always the same size.

Michael Widenius added a comment - 2014-09-30 00:46 - edited The problem is a in the stat structure at /usr/include/i386-linux-gnu/bits/stat.h Depending on how you compile your program (with or without __USE_FILE_OFFSET64) the structure gets different sizes. Here is an example: #if defined __x86_64__ || !defined __USE_FILE_OFFSET64 __off_t st_size; /* Size of file, in bytes. */ #else __off64_t st_size; /* Size of file, in bytes. */ #endif The variable is either 4 or 8 bytes, depending on the value of __USE_FILE_OFFSET64, In storage/maria/ha_maria.cc, we included files in a non standard order and struct stat got to be defined too small, which caused memory overruns. I have now fixed so that we always include <my_global.h> first, which fixes this issue. I will push this into 10.0 tree shortly However someone should fix so that 'struct stat' has always the same size, independent of how you compile it on x86. On 64 bits it's always the same size.

Sergei Golubchik made changes - 2014-09-30 01:19

Fix Version/s

10.0 [ 16000 ]

Michael Widenius added a comment - 2014-09-30 20:58

A full fix of this is now pushed to 10.0 tree, revision 4422
Sergei will push a small patch to 5.5 to fix this issue in 5.5

Michael Widenius added a comment - 2014-09-30 20:58 A full fix of this is now pushed to 10.0 tree, revision 4422 Sergei will push a small patch to 5.5 to fix this issue in 5.5

Otto Kekäläinen added a comment - 2014-10-01 07:50

I backported from commit https://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/4422 the patch http://anonscm.debian.org/cgit/pkg-mysql/mariadb-10.0.git/tree/debian/patches/fix-maria-no-logging.patch and the test passes now. Thanks!

Otto Kekäläinen added a comment - 2014-10-01 07:50 I backported from commit https://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/4422 the patch http://anonscm.debian.org/cgit/pkg-mysql/mariadb-10.0.git/tree/debian/patches/fix-maria-no-logging.patch and the test passes now. Thanks!

Sergei Golubchik made changes - 2014-10-05 12:31

Component/s		Storage Engine - Aria [ 10126 ]
Fix Version/s		10.0.15 [ 17300 ]
Fix Version/s		5.5.40 [ 17100 ]
Fix Version/s	10.0 [ 16000 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Anthony LoBono added a comment - 2014-10-10 22:55

Not sure this is the right place to report this, but installing third party libraries like mysql-python now fail with:

/usr/include/mysql/my_config.h:654:2: error: #error <my_config.h> MUST be included first!

Reporting it here, since it seems related to this issue. Please advise.

Anthony LoBono added a comment - 2014-10-10 22:55 Not sure this is the right place to report this, but installing third party libraries like mysql-python now fail with: /usr/include/mysql/my_config.h:654:2: error: #error <my_config.h> MUST be included first! Reporting it here, since it seems related to this issue. Please advise.

Sergei Golubchik made changes - 2014-10-10 23:19

Link

This issue relates to ~~MDEV-6862~~ [ ~~MDEV-6862~~ ]

Sergei Golubchik added a comment - 2014-10-10 23:22

Yes, related.

But as it's a different issue I've reported it separately. ~~MDEV-6862~~.

I cannot think of a simple workaround, besides removing this #error line from my_config.h

Sergei Golubchik added a comment - 2014-10-10 23:22 Yes, related. But as it's a different issue I've reported it separately. MDEV-6862 . I cannot think of a simple workaround, besides removing this #error line from my_config.h

Rasmus Johansson (Inactive) made changes - 2015-05-18 17:51

Workflow

MariaDB v2 [ 45013 ]

MariaDB v3 [ 65541 ]

Sergei Golubchik made changes - 2021-12-06 21:39

Workflow

MariaDB v3 [ 65541 ]

MariaDB v4 [ 147111 ]

People

Assignee:: Michael Widenius

Reporter:: Duncan Roe

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 2013-10-10 05:07

Updated:: 2014-10-10 23:22

Resolved:: 2014-10-05 12:31

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Git Integration