Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4981

Account for queries handled by query-cache in USER_STATISTICS (and in HOST_STATISTICS)

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • None
    • None

    Description

      [Affected version: at least 5.5.28a-MariaDB-log]

      When a user performs queries handled by query-cache theses are not taken into account by USER_STATISTICS (and probably neither by HOST_STATISTICS).

      They should properly increment COMMAND_SELECT, SENT_ROWS and when appropriate EMPTY_QUERIES.

      Without updating those a user that performs the same SELECT over and over, each time hitting query cache will appear as performing no queries, just burning CPU time and exchanging bytes.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-7216 COM_Select goes up together with Qcache_hits

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 5 older comments
            sanja Oleksandr Byelkin added a comment -

            QC should be transparent, so SELECT_COMMANDS should count QC answers.

            sanja Oleksandr Byelkin added a comment - QC should be transparent, so SELECT_COMMANDS should count QC answers.
            sanja Oleksandr Byelkin added a comment -

            Normal execution is fixed. now have to check SP and PS.

            sanja Oleksandr Byelkin added a comment - Normal execution is fixed. now have to check SP and PS.
            sanja Oleksandr Byelkin added a comment -

            EMPTY_QUERIES (both) counts queries with empty results (So I was wrong initially).

            sanja Oleksandr Byelkin added a comment - EMPTY_QUERIES (both) counts queries with empty results (So I was wrong initially).
            sanja Oleksandr Byelkin added a comment -

            Committed for review.

            sanja Oleksandr Byelkin added a comment - Committed for review.
            sanja Oleksandr Byelkin added a comment -

            pushed to 5.5

            sanja Oleksandr Byelkin added a comment - pushed to 5.5

            People

              sanja Oleksandr Byelkin
              bprest Bruno Prémont
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.