Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.0.4
-
None
-
None
Description
Initially reported at https://blog.mariadb.org/mariadb-10-0-4-alpha-now-available/
If server is started without InnoDB on an old datadir, mysql_upgrade fails with
Phase 3/3: Running 'mysql_fix_privilege_tables'...
|
ERROR 1286 (42000) at line 37: Unknown storage engine 'INNODB'
|
ERROR 1286 (42000) at line 46: Unknown storage engine 'INNODB'
|
FATAL ERROR: Upgrade failed
|
scripts/mysql_fix_privilege_tables.sql sets NO_ENGINE_SUBSTITUTION and then attempts to create tables using InnoDB engine, so the error is not surprising.
MySQL 5.6.13 has additional logic that checks for the presence of InnoDB and skips table creation if there is no InnoDB. However, it should be adopted with caution, because it also has a problem, later it attempts to ALTER the tables unconditionally, so mysql_upgrade fails anyway (see http://bugs.mysql.com/bug.php?id=70152).
As discussed, we should not create the tables if InnoDB is disabled (and should not attempt ALTERing them). mysql_upgrade should not fail, but it might make sense to produce a warning.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
Initially reported at https://blog.mariadb.org/mariadb-10-0-4-alpha-now-available/ If server is started without InnoDB on an old datadir, mysql_upgrade fails with {noformat} Phase 3/3: Running 'mysql_fix_privilege_tables'... ERROR 1286 (42000) at line 37: Unknown storage engine 'INNODB' ERROR 1286 (42000) at line 46: Unknown storage engine 'INNODB' FATAL ERROR: Upgrade failed {noformat} scripts/mysql_fix_privilege_tables.sql sets NO_ENGINE_SUBSTITUTION and then attempts to create tables using InnoDB engine, so the error is not surprising. MySQL 5.6.13 has additional logic that checks for the presence of InnoDB and skips table creation if there is no InnoDB. However, it should be adopted with caution, because it also has a problem, later it attempts to ALTER the tables unconditionally, so mysql_upgrade fails anyway. As discussed, we should not create the tables if InnoDB is disabled (and should not attempt ALTERing them). mysql_upgrade should not fail, but it might make sense to produce a warning. |
Initially reported at https://blog.mariadb.org/mariadb-10-0-4-alpha-now-available/ If server is started without InnoDB on an old datadir, mysql_upgrade fails with {noformat} Phase 3/3: Running 'mysql_fix_privilege_tables'... ERROR 1286 (42000) at line 37: Unknown storage engine 'INNODB' ERROR 1286 (42000) at line 46: Unknown storage engine 'INNODB' FATAL ERROR: Upgrade failed {noformat} scripts/mysql_fix_privilege_tables.sql sets NO_ENGINE_SUBSTITUTION and then attempts to create tables using InnoDB engine, so the error is not surprising. MySQL 5.6.13 has additional logic that checks for the presence of InnoDB and skips table creation if there is no InnoDB. However, it should be adopted with caution, because it also has a problem, later it attempts to ALTER the tables unconditionally, so mysql_upgrade fails anyway (see http://bugs.mysql.com/bug.php?id=70152). As discussed, we should not create the tables if InnoDB is disabled (and should not attempt ALTERing them). mysql_upgrade should not fail, but it might make sense to produce a warning. |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Attachment | mdev-4950.patch [ 23502 ] |
| Assignee | Sergey Vojtovich [ svoj ] | Sergei Golubchik [ serg ] |
| Assignee | Sergei Golubchik [ serg ] | Sergey Vojtovich [ svoj ] |
Fixed in 10.0.5, revision-id: svoj@mariadb.org-20130913084451-fu9eht7jpouid00w
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Workflow | defaullt [ 28702 ] | MariaDB v2 [ 44607 ] |
| Workflow | MariaDB v2 [ 44607 ] | MariaDB v3 [ 63958 ] |
| Workflow | MariaDB v3 [ 63958 ] | MariaDB v4 [ 146983 ] |
Sergei, please review attached patch.