Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4788

check mysql-5.5 changes in spatial.cc

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • None
    • None

    Description

      mysql-5.5.32 fixes crashes in spatial.cc.
      We've had these fixes for a while already.
      But

      • mysql fixes them slightly differently
      • it fixes less functions than we do
        we need to compare implementations, see which one to choose and it we use the upstream version — fix other functions to use the same style of checking

      Attachments

        Issue Links

          is blocked by

          Task - A task that needs to be done. MDEV-4763 5.5.32 merge

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            serg Sergei Golubchik created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            serg Sergei Golubchik added a comment -

            I've reverted mysql changes, they didn't pass our test suite. Still, please check what they were

            serg Sergei Golubchik added a comment - I've reverted mysql changes, they didn't pass our test suite. Still, please check what they were
            holyfoot Alexey Botchkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            holyfoot Alexey Botchkov added a comment -

            Patch for 5.1 pushed:
            http://lists.askmonty.org/pipermail/commits/2013-July/005106.html.

            holyfoot Alexey Botchkov added a comment - Patch for 5.1 pushed: http://lists.askmonty.org/pipermail/commits/2013-July/005106.html .
            serg Sergei Golubchik made changes -
            Fix Version/s 5.5.33 [ 13300 ]
            holyfoot Alexey Botchkov added a comment -

            Additional patch for 5.5.
            http://lists.askmonty.org/pipermail/commits/2013-October/005510.html

            holyfoot Alexey Botchkov added a comment - Additional patch for 5.5. http://lists.askmonty.org/pipermail/commits/2013-October/005510.html
            holyfoot Alexey Botchkov made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow defaullt [ 28008 ] MariaDB v2 [ 43961 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 43961 ] MariaDB v3 [ 63206 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 63206 ] MariaDB v4 [ 132170 ]

            People

              holyfoot Alexey Botchkov
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.