Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4570

[PATCH] Sys_query_cache_limit initialization depends on initialization in other source files

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.0.2, 5.5.31
    • 10.0.4, 5.5.33
    • None
    • None

    Description

      Sys_query_cache_limit variable has query_cache.query_cache_limit as a place to write its value to. But it's a member of a class that has constructor and so initialization of Sys_query_cache_limit (which assigns default value to the variable) is dependent on initialization of query_cache to happen earlier. As these variables are in different source files order of initialization between them is not defined.

      The attached patch fixes Sys_query_cache_limit to point to global variable instead of class member.

      Detected by new feature of AddressSanitizer – check_initialization_order.

      Attachments

        Activity

          People

            sanja Oleksandr Byelkin
            pivanof Pavel Ivanov
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.