Details

    • 10.1.22

    Description

      I based this task on the one on mytop : MDEV-4476

      As of this date, the innotop packaged on Debian/Ubuntu packages (and possibly other ones) of MariaDB is the 1.7.1 and the latest upstream version is the 1.9.0 from september 2012.

      1. Document changes in innotop that are in MariaDB on KB
      2. Submit patches back to upstream innotop or if no substantial modifications has been done on the MariaDB version adopt the upstream version
      3. Potentially package innotop on its own package
      4. Add MariaDB specific functionalities such as the query progress and fix bugs

      Attachments

        Issue Links

          Activity

            jb-boin Jean Weisbuch added a comment -

            Knowing that there is a bug on the 1.7.1 actually packaged (but not on the upstream latest version), it will crash if you press "f" to activate the "Show a thread's full query" option whith that error :
            Use of uninitialized value in hash element at ./innotop line 8361.

            jb-boin Jean Weisbuch added a comment - Knowing that there is a bug on the 1.7.1 actually packaged (but not on the upstream latest version), it will crash if you press "f" to activate the "Show a thread's full query" option whith that error : Use of uninitialized value in hash element at ./innotop line 8361.
            colin Colin Charles added a comment -

            Hmm, how odd. I wonder why we ship innotop in debian/additions/innotop - thanks for the report

            colin Colin Charles added a comment - Hmm, how odd. I wonder why we ship innotop in debian/additions/innotop - thanks for the report

            I'll fix it in 10.1 in my changes for debian packaging

            serg Sergei Golubchik added a comment - I'll fix it in 10.1 in my changes for debian packaging

            While at it, please move the innotop scripts out of the debian/ directory as they are more like a part of the main project and not a part of packaging.

            Downstream Debian and Ubuntu completely replace debian/* contents so any innotop bugfixes there might never come to downstream, as downstream maintain their own packaging.

            otto Otto Kekäläinen added a comment - While at it, please move the innotop scripts out of the debian/ directory as they are more like a part of the main project and not a part of packaging. Downstream Debian and Ubuntu completely replace debian/* contents so any innotop bugfixes there might never come to downstream, as downstream maintain their own packaging.

            jb-boin Do you plan on working on this? What might be the up-to-date status? I am happy to review pull requests on this topic.

            otto Otto Kekäläinen added a comment - jb-boin Do you plan on working on this? What might be the up-to-date status? I am happy to review pull requests on this topic.
            jb-boin Jean Weisbuch added a comment -

            What is the plan here : To remove innotop from the packages or to maintain it on the packages?

            As far as i remember, there were nothing changed on the version shipped with MariaDB.

            jb-boin Jean Weisbuch added a comment - What is the plan here : To remove innotop from the packages or to maintain it on the packages? As far as i remember, there were nothing changed on the version shipped with MariaDB.

            I don't know what the plan should be. I've personally never used innotop. Probably easiest to keep innotop as is, but update it (if needed).

            otto Otto Kekäläinen added a comment - I don't know what the plan should be. I've personally never used innotop. Probably easiest to keep innotop as is, but update it (if needed).
            jb-boin Jean Weisbuch added a comment -

            PR created on the 10.1 tree with the latest innotop version (i also updated the man file and the changelog) : https://github.com/MariaDB/server/pull/295

            jb-boin Jean Weisbuch added a comment - PR created on the 10.1 tree with the latest innotop version (i also updated the man file and the changelog) : https://github.com/MariaDB/server/pull/295

            People

              svoj Sergey Vojtovich
              jb-boin Jean Weisbuch
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.