[MDEV-4537] innotop tracker Created: 2013-05-16  Updated: 2017-03-07  Due: 2017-03-10  Resolved: 2017-03-07

Status: Closed
Project: MariaDB Server
Component/s: Scripts & Clients
Fix Version/s: 10.1.22

Type: Task Priority: Major
Reporter: Jean Weisbuch Assignee: Sergey Vojtovich
Resolution: Fixed Votes: 2
Labels: foundation, innotop, script

Issue Links:
Blocks
is blocked by MDEV-6284 Merge downstream Debian/Ubuntu packag... Closed
PartOf
is part of MDEV-3809 Change Debian packaging to use CPack ... Stalled
Sprint: 10.1.22

 Description   

I based this task on the one on mytop : MDEV-4476

As of this date, the innotop packaged on Debian/Ubuntu packages (and possibly other ones) of MariaDB is the 1.7.1 and the latest upstream version is the 1.9.0 from september 2012.

1. Document changes in innotop that are in MariaDB on KB
2. Submit patches back to upstream innotop or if no substantial modifications has been done on the MariaDB version adopt the upstream version
3. Potentially package innotop on its own package
4. Add MariaDB specific functionalities such as the query progress and fix bugs

 Comments   
Comment by Jean Weisbuch [ 2013-05-16 ]

Knowing that there is a bug on the 1.7.1 actually packaged (but not on the upstream latest version), it will crash if you press "f" to activate the "Show a thread's full query" option whith that error :
Use of uninitialized value in hash element at ./innotop line 8361.

Comment by Colin Charles [ 2013-05-16 ]

Hmm, how odd. I wonder why we ship innotop in debian/additions/innotop - thanks for the report

Comment by Sergei Golubchik [ 2014-04-10 ]

I'll fix it in 10.1 in my changes for debian packaging

Comment by Otto Kekäläinen [ 2015-07-21 ]

While at it, please move the innotop scripts out of the debian/ directory as they are more like a part of the main project and not a part of packaging.

Downstream Debian and Ubuntu completely replace debian/* contents so any innotop bugfixes there might never come to downstream, as downstream maintain their own packaging.

Comment by Otto Kekäläinen [ 2016-11-25 ]

jb-boin Do you plan on working on this? What might be the up-to-date status? I am happy to review pull requests on this topic.

Comment by Jean Weisbuch [ 2016-11-25 ]

What is the plan here : To remove innotop from the packages or to maintain it on the packages?

As far as i remember, there were nothing changed on the version shipped with MariaDB.

Comment by Otto Kekäläinen [ 2016-11-26 ]

I don't know what the plan should be. I've personally never used innotop. Probably easiest to keep innotop as is, but update it (if needed).

Comment by Jean Weisbuch [ 2017-01-23 ]

PR created on the 10.1 tree with the latest innotop version (i also updated the man file and the changelog) : https://github.com/MariaDB/server/pull/295

Generated at Thu Feb 08 06:57:11 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.