Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4447

MariaDB sources should have unix-style line endings everywhere

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.0.2
    • Fix Version/s: 5.5.44, 10.0.20
    • Component/s: OTHER
    • Labels:
      None
    • Sprint:
      5.5.44

      Description

      Is it feasible to clean up all MariaDB sources and set unix-style line endings everywhere?
      Currently running "grep -IUrl $'\r' *" reveals 68 files that have either Windows-style line endings or mixed-style line endings, about 10 of them are source files. I realize that many of those 68 are files used only on Windows, but I believe all modern tools on Windows work with unix-style line endings without problem. Meanwhile not having unix-style line endings everywhere doesn't allow to put MariaDB's tarball as-is into git repository when core.safecrlf is set to true in .gitconfig.

        Attachments

        1. connect_files.txt
          0.8 kB
        2. other_files.txt
          2 kB
        3. spider_files.txt
          8 kB
        4. tokudb_files.txt
          1 kB

          Activity

            People

            • Assignee:
              serg Sergei Golubchik
              Reporter:
              pivanof Pavel Ivanov
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: