Please consider the attached patch that fixes compilation warnings (that turn into errors with -Werror) occurring when compiling MariaDB 10.0.1 with clang. Feel free to adjust it if you think that some warnings should be fixed differently.
{"report":{"fcp":979.8000000119209,"ttfb":258.60000002384186,"pageVisibility":"visible","entityId":23208,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"6edee891-2ebf-4a8c-98c0-867c5071a97f","navigationType":0,"readyForUser":1094.199999988079,"redirectCount":0,"resourceLoadedEnd":685.8000000119209,"resourceLoadedStart":284,"resourceTiming":[{"duration":27.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":284,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":284,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":311.5,"responseStart":0,"secureConnectionStart":0},{"duration":27.80000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":284.39999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":284.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":312.19999998807907,"responseStart":0,"secureConnectionStart":0},{"duration":278.89999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":284.60000002384186,"connectEnd":315,"connectStart":315,"domainLookupEnd":315,"domainLookupStart":315,"fetchStart":284.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":315.30000001192093,"responseEnd":563.5,"responseStart":330.80000001192093,"secureConnectionStart":315},{"duration":400.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":285.19999998807907,"connectEnd":285.19999998807907,"connectStart":285.19999998807907,"domainLookupEnd":285.19999998807907,"domainLookupStart":285.19999998807907,"fetchStart":285.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":316.19999998807907,"responseEnd":685.8000000119209,"responseStart":339.5,"secureConnectionStart":285.19999998807907},{"duration":53.700000047683716,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":285.39999997615814,"connectEnd":285.39999997615814,"connectStart":285.39999997615814,"domainLookupEnd":285.39999997615814,"domainLookupStart":285.39999997615814,"fetchStart":285.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":316.60000002384186,"responseEnd":339.10000002384186,"responseStart":334.60000002384186,"secureConnectionStart":285.39999997615814},{"duration":55.69999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":285.60000002384186,"connectEnd":285.60000002384186,"connectStart":285.60000002384186,"domainLookupEnd":285.60000002384186,"domainLookupStart":285.60000002384186,"fetchStart":285.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":317.5,"responseEnd":341.30000001192093,"responseStart":336.80000001192093,"secureConnectionStart":285.60000002384186},{"duration":65.40000003576279,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":285.69999998807907,"connectEnd":285.69999998807907,"connectStart":285.69999998807907,"domainLookupEnd":285.69999998807907,"domainLookupStart":285.69999998807907,"fetchStart":285.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":318.60000002384186,"responseEnd":351.10000002384186,"responseStart":347.60000002384186,"secureConnectionStart":285.69999998807907},{"duration":32.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":285.89999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":285.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":318.5,"responseStart":0,"secureConnectionStart":0},{"duration":75.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":286.10000002384186,"connectEnd":286.10000002384186,"connectStart":286.10000002384186,"domainLookupEnd":286.10000002384186,"domainLookupStart":286.10000002384186,"fetchStart":286.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":325.60000002384186,"responseEnd":361.89999997615814,"responseStart":354.5,"secureConnectionStart":286.10000002384186},{"duration":33.40000003576279,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":286.19999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":286.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":319.60000002384186,"responseStart":0,"secureConnectionStart":0},{"duration":76.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":286.30000001192093,"connectEnd":286.30000001192093,"connectStart":286.30000001192093,"domainLookupEnd":286.30000001192093,"domainLookupStart":286.30000001192093,"fetchStart":286.30000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":325.89999997615814,"responseEnd":362.60000002384186,"responseStart":355.69999998807907,"secureConnectionStart":286.30000001192093},{"duration":386.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":296.39999997615814,"connectEnd":296.39999997615814,"connectStart":296.39999997615814,"domainLookupEnd":296.39999997615814,"domainLookupStart":296.39999997615814,"fetchStart":296.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":363.10000002384186,"responseEnd":682.8999999761581,"responseStart":671.3000000119209,"secureConnectionStart":296.39999997615814},{"duration":388.10000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":296.5,"connectEnd":296.5,"connectStart":296.5,"domainLookupEnd":296.5,"domainLookupStart":296.5,"fetchStart":296.5,"redirectEnd":0,"redirectStart":0,"requestStart":405.5,"responseEnd":684.6000000238419,"responseStart":676.5,"secureConnectionStart":296.5},{"duration":126,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":719.6000000238419,"connectEnd":719.6000000238419,"connectStart":719.6000000238419,"domainLookupEnd":719.6000000238419,"domainLookupStart":719.6000000238419,"fetchStart":719.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":805,"responseEnd":845.6000000238419,"responseStart":843.3999999761581,"secureConnectionStart":719.6000000238419},{"duration":154.10000002384186,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":971.3999999761581,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":971.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1125.5,"responseStart":0,"secureConnectionStart":0},{"duration":148.30000001192093,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":978.8000000119209,"connectEnd":978.8000000119209,"connectStart":978.8000000119209,"domainLookupEnd":978.8000000119209,"domainLookupStart":978.8000000119209,"fetchStart":978.8000000119209,"redirectEnd":0,"redirectStart":0,"requestStart":1091.800000011921,"responseEnd":1127.1000000238419,"responseStart":1123.699999988079,"secureConnectionStart":978.8000000119209}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":94,"responseStart":259,"responseEnd":296,"domLoading":263,"domInteractive":1152,"domContentLoadedEventStart":1152,"domContentLoadedEventEnd":1192,"domComplete":1449,"loadEventStart":1449,"loadEventEnd":1449,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1127.5},{"name":"bigPipe.sidebar-id.end","time":1128.199999988079},{"name":"bigPipe.activity-panel-pipe-id.start","time":1128.3999999761581},{"name":"bigPipe.activity-panel-pipe-id.end","time":1129.800000011921},{"name":"activityTabFullyLoaded","time":1213}],"measures":[],"correlationId":"6262250451f46c","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":103,"dbReadsTimeInMs":12,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
I've applied most of your patches.
I didn't apply changes to include/probes_mysql_nodtrace.h, sql/item.cc, sql/unireg.cc.
Could you please clarify what warnings exactly did you get there?