Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-40791

SET GLOBAL innodb_log_archive=OFF triggers full flush

    XMLWordPrintable

Details

    • Related to performance
    • An unnecessary write of the entire buffer pool could be triggered by SET GLOBAL innodb_log_archive=OFF.

    Description

      During the testing of MDEV-14992 it turned out that disabling the log archiving by executing

      SET GLOBAL innodb_log_archive=OFF;
      

      would trigger a full buffer pool flush:

      a848493c6fe031f23606144420c1ca1e467cbd81:storage/innobase/log/log0log.cc

      796
            wait_lsn= 0;
      797
          retry_after_checkpoint:
      798
            IF_WIN(log_resize_release_locks(),);
      799
            if (wait_lsn)
      800
            {
      801
              mysql_mutex_lock(&buf_pool.flush_list_mutex);
      802
              buf_flush_wait(wait_lsn, false);
      803
              mysql_mutex_unlock(&buf_pool.flush_list_mutex);
      804
            }
      805
            latch.wr_unlock();
      806
            continue;
      

      In my test scenario, the log file format is being changed in place.

      If we made innodb_log_archive=ON write the sequence bit exactly in the same way as innodb_log_archive=OFF, then the wait for an extra checkpoint should be avoidable.

      Attachments

        Issue Links

          Activity

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Marko Mäkelä Marko Mäkelä
              Thirunarayanan Balathandayuthapani Thirunarayanan Balathandayuthapani
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 7.25h
                  7.25h

                  Git Integration

                    Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.