Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-40023

Clean up dead code in check_expected_crash_and_restart

    XMLWordPrintable

Details

    Description

      check_expected_crash_and_restart() in mariadb-test-run.pl contains dead code for restart_bindir (never used by any test) and silently ignores unknown commands in the expect file. This made it easy for bugs like https://jira.mariadb.org/browse/MDEV-39153 to go undetected.

      Remove the unused restart_bindir handler from mariadb-test-run.pl and start_mysqld.inc

      Call mtr_error() when an unrecognized command is found in the expect file

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-39153 Sporadic `main.change_master_default` mismatch

          • Critical - Crashes, loss of data, severe memory leak.
          • In Review

          Activity

            People

              gkodinov Georgi Kodinov
              farihais Fariha Shaikh
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 10m
                  10m

                  Git Integration

                    Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.