Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-39784

mariadb 10.11.18 fails test plugins.feedback_os_release

    XMLWordPrintable

Details

    • Not for Release Notes

    Description

      Testing ./mysql-test/mysql-test-run.pl plugins.feedback_os_release fails:

      CURRENT_TEST: plugins.feedback_os_release
      mysqltest: At line 50: query 'if (`select '$plugin_val' = ''`)
      {' failed: ER_PARSE_ERROR (1064): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'Linux'' = ''' at line 1
      

      and

      CURRENT_TEST: plugins.feedback_os_release
      mysqltest: At line 57: query 'if (`select '$plugin_val' != '$expected_val'`)
      {' failed: ER_PARSE_ERROR (1064): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'Linux'' != 'os-release: 'Gentoo Linux''' at line 1
      

      It works with this quoting:

      --- mysql-test/suite/plugins/t/feedback_os_release.test.virgin  2026-05-28 14:38:52.087468423 +0000
      +++ mysql-test/suite/plugins/t/feedback_os_release.test 2026-05-28 14:39:35.426469465 +0000
      @@ -47,14 +47,14 @@
                         where variable_name = 'Uname_distribution'`;
       
       # Skip if plugin returned empty (e.g. FreeBSD with MTR_FEEDBACK_PLUGIN=0)
      -if (`select '$plugin_val' = ''`)
      +if (`select "$plugin_val" = ""`)
       {
         --skip Uname_distribution not available on this platform
       }
       
       let $expected_val= `select TRIM(LOAD_FILE('$MYSQLTEST_VARDIR/tmp/mdev39126_pretty_name'))`;
       
      -if (`select '$plugin_val' != '$expected_val'`)
      +if (`select "$plugin_val" != "$expected_val"`)
       {
         --echo Mismatch! Plugin: '$plugin_val'
         --echo Expected:         '$expected_val'
      

      This was tested on Gentoo Linux, /etc/os-release looks like:

      NAME='Gentoo'
      ID='gentoo'
      PRETTY_NAME='Gentoo Linux'
      VERSION='2.18'
      VERSION_ID='2.18'
      HOME_URL='https://www.gentoo.org/'
      SUPPORT_URL='https://www.gentoo.org/support/'
      BUG_REPORT_URL='https://bugs.gentoo.org/'
      ANSI_COLOR='1;32'
      

      Attachments

        Issue Links

          Activity

            People

              danblack Daniel Black
              hydrapolic Tomáš Mózes
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.