Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-39516

s3 curl_easy_setopt requires long values otherwise compile failure

    XMLWordPrintable

Details

    • Not for Release Notes

    Description

      Libcurl 8.18.0 from Fedora 44 errors with numberious non-long values passes to curl_easy_setopt.

      Documentaiton https://curl.se/libcurl/c/curl_easy_setopt.html indicates that long is required.

      Generated errors on 10.11 are:

      ibute: curl_easy_setopt expects a long argument [-Werror,-Wattribute-warning]
        875 |     curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0);
            |     ^
      /usr/include/curl/typecheck-gcc.h:50:15: note: expanded from macro 'curl_easy_setopt'
         50 |               Wcurl_easy_setopt_err_long();                             \
            |               ^
      /home/dan/repos/mariadb-server-10.11/storage/maria/libmarias3/src/request.c:874:5: error: call to 'Wcurl_easy_setopt_err_long' declared with 'warning' attribute: curl_easy_setopt expects a long argument [-Werror,-Wattribute-warning]
        874 |     curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0);
            |     ^
      /usr/include/curl/typecheck-gcc.h:50:15: note: expanded from macro 'curl_easy_setopt'
         50 |               Wcurl_easy_setopt_err_long();                             \
            |               ^
      /home/dan/repos/mariadb-server-10.11/storage/maria/libmarias3/src/request.c:883:5: error: call to 'Wcurl_easy_setopt_err_long' declared with 'warning' attribute: curl_easy_setopt expects a long argument [-Werror,-Wattribute-warning]
        883 |     curl_easy_setopt(ms3->curl, CURLOPT_CONNECTTIMEOUT_MS, ms3->connect_timeout_ms);
            |     ^
      /usr/include/curl/typecheck-gcc.h:50:15: note: expanded from macro 'curl_easy_setopt'
         50 |               Wcurl_easy_setopt_err_long();                             \
            |               ^
      /home/dan/repos/mariadb-server-10.11/storage/maria/libmarias3/src/request.c:888:5: error: call to 'Wcurl_easy_setopt_err_long' declared with 'warning' attribute: curl_easy_setopt expects a long argument [-Werror,-Wattribute-warning]
        888 |     curl_easy_setopt(ms3->curl, CURLOPT_TIMEOUT_MS, ms3->timeout_ms);
            |     ^
      /usr/include/curl/typecheck-gcc.h:50:15: note: expanded from macro 'curl_easy_setopt'
         50 |               Wcurl_easy_setopt_err_long();                             \
            |               ^
      /home/dan/repos/mariadb-server-10.11/storage/maria/libmarias3/src/request.c:904:3: error: call to 'Wcurl_easy_setopt_err_long' declared with 'warning' attribute: curl_easy_setopt expects a long argument [-Werror,-Wattribute-warning]
        904 |   curl_easy_setopt(curl, CURLOPT_VERBOSE, ms3debug_get());
            |   ^
      /usr/include/curl/typecheck-gcc.h:50:15: note: expanded from macro 'curl_easy_setopt'
         50 |               Wcurl_easy_setopt_err_long();                             \
            |               ^
      /home/dan/repos/mariadb-server-10.11/storage/maria/libmarias3/src/request.c:903:3: error: call to 'Wcurl_easy_setopt_err_long' declared with 'warning' attribute: curl_easy_setopt expects a long argument [-Werror,-Wattribute-warning]
        903 |   curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1);
            |   ^
      /usr/include/curl/typecheck-gcc.h:50:15: note: expanded from macro 'curl_easy_setopt'
         50 |               Wcurl_easy_setopt_err_long();                             \
            |               ^
      

      Raised as issue - https://github.com/mariadb-corporation/libmarias3/issues/141

      Correction available - https://github.com/mariadb-corporation/libmarias3/issues/141

      Attachments

        Issue Links

          Activity

            People

              serg Sergei Golubchik
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.