Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-39189

XXH SIMD acceleration is not being enabled

    XMLWordPrintable

Details

    • Related to performance

    Description

      As far as I can tell, the SIMD algorithms that have been implemented in the source code file mysys/xxhash.h are never put into use, because the preprocessor symbol XXH_ENABLE_AUTOVECTORIZE is never defined.

      If I understood it correctly, this header file has been designed so that it can be included in ISA extension specific compilation units that would be compiled with additional flags, such as -mavx512 to enable those extensions.

      It seems that we'd have to implement CPU detection in strings/hasher-xxh.c similar to what has been done in various files in mysys/crc32, and enable the most efficient implementation that is available at runtime.

      Attachments

        Issue Links

          Activity

            People

              ycp Yuchen Pei
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.