Details
-
Bug
-
Status: Confirmed (View Workflow)
-
Major
-
Resolution: Unresolved
-
12.3
-
Related to performance
Description
As far as I can tell, the SIMD algorithms that have been implemented in the source code file mysys/xxhash.h are never put into use, because the preprocessor symbol XXH_ENABLE_AUTOVECTORIZE is never defined.
If I understood it correctly, this header file has been designed so that it can be included in ISA extension specific compilation units that would be compiled with additional flags, such as -mavx512 to enable those extensions.
It seems that we'd have to implement CPU detection in strings/hasher-xxh.c similar to what has been done in various files in mysys/crc32, and enable the most efficient implementation that is available at runtime.
Attachments
Issue Links
- relates to
-
MDEV-9826 better hash algorithms for PARTITION BY KEY
-
- Closed
-
-
MDEV-39168 XXH fails to build with GCC 14+ -Og -mavx512f
-
- Closed
-
-
MDEV-39188 Dead code XXH3_len_17to128_64b()
-
- Confirmed
-