Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-39173

Remove the -Wdeprecated-declarations from violite.h and convert sprintfs to snprintfs

    XMLWordPrintable

Details

    Description

      server-main/include/violite.h has the following fragment for MacOSX:

      /* apple deprecated openssl in MacOSX Lion */
      #ifdef __APPLE__
      #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
      #endif
      

      The MacOSX versions that actually do have openssl headers are long being deprecated. Nowadays MacOSX binaries are compiled against the stock openssl library and headers and these do not have deprecation warnings built into them.

      It's time to remove this warning suppression.

      But the removal results in 100 or so "sprintf is deprecated" warnings.

      So these should be fixed as well.

      Attachments

        1. warnings.txt
          151 kB
          Georgi Kodinov

        Issue Links

          Activity

            People

              Unassigned Unassigned
              gkodinov Georgi Kodinov
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.