Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-38853

Json_writer missing #if ... #endif to exclude VALIDITY_ASSERT

    XMLWordPrintable

Details

    • Bug
    • Status: Stalled (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 10.5(EOL), 10.6, 10.11, 11.4, 11.8, 12.3
    • 10.6
    • JSON

    Description

      mariadb-LTS : update versions, boost188, new LTS ports 11.8, 12.3#28680

      When switching from PortGroup cmake 1.0 to 1.1 the following issues appeared :

      make[2]: *** [libmysqld/CMakeFiles/sql_embedded.dir/__/sql/my_json_writer.cc.o] Error 1
      make[1]: *** [libmysqld/CMakeFiles/sql_embedded.dir/all] Error 2
      make[2]: *** [sql/CMakeFiles/sql.dir/my_json_writer.cc.o] Error 1
      make[1]: *** [sql/CMakeFiles/sql.dir/all] Error 2
      make: *** [all] Error 2
      DEBUG: Error code: CHILDSTATUS 49126 2
      

      mariadb-12.3.1/sql/my_json_writer.cc:260:31: error: use of undeclared identifier 'named_item_expected'
      mariadb-12.3.1/sql/my_json_writer.cc:260:19: error: use of undeclared identifier 'got_name'
      mariadb-12.3.1/sql/my_json_writer.cc:293:31: error: use of undeclared identifier 'named_item_expected'
      mariadb-12.3.1/sql/my_json_writer.cc:293:19: error: use of undeclared identifier 'got_name'
      

      It seems to be caused by missing :

      #if !defined(NDEBUG) || defined(JSON_WRITER_UNIT_TEST)
      ...
      #endif
      

      around the VALIDITY_ASSERT parts of the two functions :

      Json_writer::add_unquoted_str
      Json_writer::add_str
      

      in sql/my_json_writer.cc

      Patch-files for all the LTS versions can be found in the above PR28680

      Attachments

        Activity

          People

            gkodinov Georgi Kodinov
            BjarneDM Bjarne D Mathiesen
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.