Details
-
Task
-
Status: Open (View Workflow)
-
Critical
-
Resolution: Unresolved
Description
Many old spider tests are obscured by variables and some of them are very long. A typical example is spider_fixes.test. Table creations are hidden behind variables such as $CHILD2_1_CREATE_TABLES6 and $MASTER_1_COMMENT5_2_1. It has almost 1500 lines that are not arranged in blocks of independent tests like a normal test file, so whenever a test breaks it is time-consuming to narrow down a small block to reproduce the test.
Here's a rough list of such tests (80+ in total), based on a search for a telltale sign "eval $CHILD":
$ git grep -l "eval \$CHILD"
|
storage/spider/mysql-test/spider/bg/t/basic_sql.test
|
storage/spider/mysql-test/spider/bg/t/basic_sql_part.test
|
storage/spider/mysql-test/spider/bg/t/direct_aggregate.test
|
storage/spider/mysql-test/spider/bg/t/direct_aggregate_part.test
|
storage/spider/mysql-test/spider/bg/t/direct_update.test
|
storage/spider/mysql-test/spider/bg/t/direct_update_part.test
|
storage/spider/mysql-test/spider/bg/t/function.test
|
storage/spider/mysql-test/spider/bg/t/ha.test
|
storage/spider/mysql-test/spider/bg/t/ha_part.test
|
storage/spider/mysql-test/spider/bg/t/spider3_fixes.test
|
storage/spider/mysql-test/spider/bg/t/spider3_fixes_part.test
|
storage/spider/mysql-test/spider/bg/t/spider_fixes.test
|
storage/spider/mysql-test/spider/bg/t/spider_fixes_part.test
|
storage/spider/mysql-test/spider/bg/t/vp_fixes.test
|
storage/spider/mysql-test/spider/bugfix/t/checksum_table_with_quick_mode_3.test
|
storage/spider/mysql-test/spider/bugfix/t/cp932_column.test
|
storage/spider/mysql-test/spider/bugfix/t/delete_with_float_column.inc
|
storage/spider/mysql-test/spider/bugfix/t/group_by_order_by_limit.test
|
storage/spider/mysql-test/spider/bugfix/t/insert_select.test
|
storage/spider/mysql-test/spider/bugfix/t/mdev_19866.test
|
storage/spider/mysql-test/spider/bugfix/t/mdev_20100.test
|
storage/spider/mysql-test/spider/bugfix/t/mdev_20502.test
|
storage/spider/mysql-test/spider/bugfix/t/mdev_21884.test
|
storage/spider/mysql-test/spider/bugfix/t/mdev_22246.test
|
storage/spider/mysql-test/spider/bugfix/t/mdev_24020.test
|
storage/spider/mysql-test/spider/bugfix/t/mdev_24517.test
|
storage/spider/mysql-test/spider/bugfix/t/mdev_24523.test
|
storage/spider/mysql-test/spider/bugfix/t/quick_mode_0.test
|
storage/spider/mysql-test/spider/bugfix/t/quick_mode_1.test
|
storage/spider/mysql-test/spider/bugfix/t/quick_mode_2.test
|
storage/spider/mysql-test/spider/bugfix/t/quick_mode_3.test
|
storage/spider/mysql-test/spider/bugfix/t/return_found_rows_insert.test
|
storage/spider/mysql-test/spider/bugfix/t/return_found_rows_update.test
|
storage/spider/mysql-test/spider/bugfix/t/select_by_null.test
|
storage/spider/mysql-test/spider/bugfix/t/select_with_backquote.test
|
storage/spider/mysql-test/spider/bugfix/t/slave_trx_isolation.test
|
storage/spider/mysql-test/spider/bugfix/t/sql_mode.inc
|
storage/spider/mysql-test/spider/bugfix/t/strict_group_by.test
|
storage/spider/mysql-test/spider/bugfix/t/wait_timeout.test
|
storage/spider/mysql-test/spider/bugfix/t/wrapper_mariadb.test
|
storage/spider/mysql-test/spider/bugfix/t/xa_cmd.test
|
storage/spider/mysql-test/spider/feature/t/checksum_table_parallel.inc
|
storage/spider/mysql-test/spider/regression/e1121/t/direct_join_by_pkey_key.test
|
storage/spider/mysql-test/spider/regression/e1121/t/direct_join_by_pkey_pkey.test
|
storage/spider/mysql-test/spider/regression/e1121/t/load_data.inc
|
storage/spider/mysql-test/spider/regression/e112122/t/group_by_order_by_limit_ok.test
|
storage/spider/mysql-test/spider/regression/e112122/t/load_data_part.inc
|
storage/spider/mysql-test/spider/t/auto_increment.test
|
storage/spider/mysql-test/spider/t/basic_sql.test
|
storage/spider/mysql-test/spider/t/basic_sql_part.test
|
storage/spider/mysql-test/spider/t/checksum_table_with_quick_mode_3.test
|
storage/spider/mysql-test/spider/t/direct_aggregate.test
|
storage/spider/mysql-test/spider/t/direct_aggregate_part.test
|
storage/spider/mysql-test/spider/t/direct_join.test
|
storage/spider/mysql-test/spider/t/direct_join_using.test
|
storage/spider/mysql-test/spider/t/direct_left_join.test
|
storage/spider/mysql-test/spider/t/direct_left_join_nullable.test
|
storage/spider/mysql-test/spider/t/direct_left_right_join_nullable.test
|
storage/spider/mysql-test/spider/t/direct_left_right_left_join_nullable.test
|
storage/spider/mysql-test/spider/t/direct_right_join.test
|
storage/spider/mysql-test/spider/t/direct_right_join_nullable.test
|
storage/spider/mysql-test/spider/t/direct_right_left_join_nullable.test
|
storage/spider/mysql-test/spider/t/direct_right_left_right_join_nullable.test
|
storage/spider/mysql-test/spider/t/direct_update.test
|
storage/spider/mysql-test/spider/t/direct_update_part.test
|
storage/spider/mysql-test/spider/t/function.test
|
storage/spider/mysql-test/spider/t/ha.test
|
storage/spider/mysql-test/spider/t/ha_part.test
|
storage/spider/mysql-test/spider/t/partition_cond_push.test
|
storage/spider/mysql-test/spider/t/partition_fulltext.test
|
storage/spider/mysql-test/spider/t/partition_join_pushdown_for_single_partition.test
|
storage/spider/mysql-test/spider/t/partition_mrr.test
|
storage/spider/mysql-test/spider/t/pushdown_not_like.test
|
storage/spider/mysql-test/spider/t/quick_mode_0.test
|
storage/spider/mysql-test/spider/t/quick_mode_1.test
|
storage/spider/mysql-test/spider/t/quick_mode_2.test
|
storage/spider/mysql-test/spider/t/quick_mode_3.test
|
storage/spider/mysql-test/spider/t/slave_trx_isolation.test
|
storage/spider/mysql-test/spider/t/spider3_fixes.test
|
storage/spider/mysql-test/spider/t/spider3_fixes_part.test
|
storage/spider/mysql-test/spider/t/spider_fixes.test
|
storage/spider/mysql-test/spider/t/spider_fixes_part.test
|
storage/spider/mysql-test/spider/t/timestamp.test
|
storage/spider/mysql-test/spider/t/udf_pushdown.test
|
storage/spider/mysql-test/spider/t/vp_fixes.test
|
Attachments
Issue Links
- is part of
-
MDEV-26286 Refactor Spider storage engine
-
- Open
-