[MDEV-36442] spider tests with --view-protocol fail with diff SELECT argument FROM mysql.general_log ... - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.5
Fix Version/s: 10.5.29, 10.6.22, 10.11.12, 11.4.6, 11.8.2
Component/s: Storage Engine - Spider
Labels:
None

Description

Example

spider/bugfix.checksum_table_with_quick_mode_3 [ fail ]

        Test ended at 2025-03-31 17:43:49

CURRENT_TEST: spider/bugfix.checksum_table_with_quick_mode_3

--- /home/ycp/source/mariadb-server/10.5/src/storage/spider/mysql-test/spider/bugfix/r/checksum_table_with_quick_mode_3.result	2024-10-14 17:39:33.521086990 +1100

+++ /home/ycp/source/mariadb-server/10.5/src/storage/spider/mysql-test/spider/bugfix/r/checksum_table_with_quick_mode_3.reject	2025-03-31 17:43:48.667783126 +1100

@@ -47,7 +47,7 @@

 SELECT argument FROM mysql.general_log WHERE argument LIKE '%checksum %';

 argument

 checksum table `auto_test_remote`.`tbl_a` extended

-SELECT argument FROM mysql.general_log WHERE argument LIKE '%checksum %'

+CREATE OR REPLACE VIEW mysqltest_tmp_v AS SELECT argument FROM mysql.general_log WHERE argument LIKE '%checksum %'

 SELECT pkey FROM tbl_a ORDER BY pkey;

 pkey

Result length mismatch

Attachments

Issue Links

is part of

MDEV-35452 Always failing spider tests on Debug Last-N builder with --view-protocol

Closed

Activity

Ascending order - Click to sort in descending order

Yuchen Pei added a comment - 2025-03-31 08:48

It should be as simple as surrounding these statements with --disable_view_protocol and --enable_view_protocol, except it's not that simple...

For example if we do this for spider/bugfix.mdev_20100 we get strange failure like so

spider/bugfix.mdev_20100                 [ fail ]

        Test ended at 2025-03-31 17:48:58

CURRENT_TEST: spider/bugfix.mdev_20100

mysqltest: At line 78: Failed to drop view: 0:

The result from queries just before the failure was:

< snip >

5	c	2001-12-31 23:59:59

connection child2_1;

SELECT argument FROM mysql.general_log WHERE argument LIKE '%select %';

argument

select `a`,`b`,`c` from `auto_test_remote`.`ta_r3` where (`b` = 'c')

select `a`,`b`,`c` from `auto_test_remote`.`ta_r2`

select `a`,`b`,`c` from `auto_test_remote`.`ta_r3`

select `a`,`b`,`c` from `auto_test_remote`.`ta_r4` where (`b` = 'c')

select `a`,`b`,`c` from `auto_test_remote`.`ta_r2`

select `a`,`b`,`c` from `auto_test_remote`.`ta_r3`

select `a`,`b`,`c` from `auto_test_remote`.`ta_r2` where (`b` = 'c')

select `a`,`b`,`c` from `auto_test_remote`.`ta_r2`

select `a`,`b`,`c` from `auto_test_remote`.`ta_r4`

select `a`,`b`,`c` from `auto_test_remote`.`ta_r2` where (`b` = 'c')

select `a`,`b`,`c` from `auto_test_remote`.`ta_r3`

select `a`,`b`,`c` from `auto_test_remote`.`ta_r4`

SELECT argument FROM mysql.general_log WHERE argument LIKE '%select %'

SELECT a, b, c FROM ta_r2 ORDER BY a ;

SELECT a, b, c FROM ta_r3 ORDER BY a ;

SELECT a, b, c FROM ta_r4 ORDER BY a;

Yuchen Pei added a comment - 2025-03-31 08:48 It should be as simple as surrounding these statements with --disable_view_protocol and --enable_view_protocol , except it's not that simple... For example if we do this for spider/bugfix.mdev_20100 we get strange failure like so spider/bugfix.mdev_20100 [ fail ] Test ended at 2025-03-31 17:48:58 CURRENT_TEST: spider/bugfix.mdev_20100 mysqltest: At line 78: Failed to drop view: 0: The result from queries just before the failure was: < snip > 5 c 2001-12-31 23:59:59 connection child2_1; SELECT argument FROM mysql.general_log WHERE argument LIKE '%select %'; argument select `a`,`b`,`c` from `auto_test_remote`.`ta_r3` where (`b` = 'c') select `a`,`b`,`c` from `auto_test_remote`.`ta_r2` select `a`,`b`,`c` from `auto_test_remote`.`ta_r3` select `a`,`b`,`c` from `auto_test_remote`.`ta_r4` where (`b` = 'c') select `a`,`b`,`c` from `auto_test_remote`.`ta_r2` select `a`,`b`,`c` from `auto_test_remote`.`ta_r3` select `a`,`b`,`c` from `auto_test_remote`.`ta_r2` where (`b` = 'c') select `a`,`b`,`c` from `auto_test_remote`.`ta_r2` select `a`,`b`,`c` from `auto_test_remote`.`ta_r4` select `a`,`b`,`c` from `auto_test_remote`.`ta_r2` where (`b` = 'c') select `a`,`b`,`c` from `auto_test_remote`.`ta_r3` select `a`,`b`,`c` from `auto_test_remote`.`ta_r4` SELECT argument FROM mysql.general_log WHERE argument LIKE '%select %' SELECT a, b, c FROM ta_r2 ORDER BY a ; SELECT a, b, c FROM ta_r3 ORDER BY a ; SELECT a, b, c FROM ta_r4 ORDER BY a;

Yuchen Pei added a comment - 2025-04-01 03:55 - edited

Hi holyfoot, ptal thanks

2c6f6922020 upstream/bb-10.5-mdev-36442 MDEV-36442 MDEV-35452 Fix --view-protocol for spider tests with SELECT arguments of SELECT statements

I think the issue mentioned in the previous comment is a separate issue so it will be addressed separately

Yuchen Pei added a comment - 2025-04-01 03:55 - edited Hi holyfoot , ptal thanks 2c6f6922020 upstream/bb-10.5-mdev-36442 MDEV-36442 MDEV-35452 Fix --view-protocol for spider tests with SELECT arguments of SELECT statements I think the issue mentioned in the previous comment is a separate issue so it will be addressed separately

Alexey Botchkov added a comment - 2025-04-07 21:21

ok to push.

Alexey Botchkov added a comment - 2025-04-07 21:21 ok to push.

Yuchen Pei added a comment - 2025-04-08 03:34

Thanks for the review - pushed 59962ae2b3061dbd3694e005c779d9b2dfbf625c to 10.5

Yuchen Pei added a comment - 2025-04-08 03:34 Thanks for the review - pushed 59962ae2b3061dbd3694e005c779d9b2dfbf625c to 10.5

People

Assignee:: Yuchen Pei

Reporter:: Yuchen Pei

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2025-03-31 06:46

Updated:: 2025-04-08 03:34

Resolved:: 2025-04-08 03:34

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server