[MDEV-36381] Comment "Procedure of keys generation ..." is in the wrong place - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Trivial
Resolution: Fixed
Affects Version/s: 10.5, 10.11
Fix Version/s: 10.11.12, 11.4.6, 11.8.2
Component/s: Optimizer
Labels:
None

Description

In current code, we have in table.cc:

/*

  Procedure of keys generation for result tables of materialized derived

  tables/views.

  A key is generated for each equi-join pair derived table-another table.

...

*/

/*

  @brief

  Change references to underlying items of a merged derived table/view

  for fields in derived table's result table.

  @return FALSE ok

  @return TRUE  Out of memory

*/

bool TABLE_LIST::change_refs_to_fields()

The first comment is out of place.
It should have been at sql_select.cc, generate_derived_keys().

The comment was added in this commit:

commit 709a0a131021135e9fb7a2095fcfcbc223dfb126

Author: Igor Babaev <igor@askmonty.org>

Date:   Wed May 26 13:18:18 2010 -0700

    MWL#106: Backport optimizations for derived tables and views.

    The main consolidated patch.

generate_derived_keys() was also introduced in the same commit.

Attachments

Activity

Ascending order - Click to sort in descending order

Sergei Petrunia created issue - 2025-03-25 12:25

Sergei Petrunia made changes - 2025-03-25 12:26

Field	Original Value	New Value
Description	In current code, we have in table.cc: {code:cpp} /* Procedure of keys generation for result tables of materialized derived tables/views. A key is generated for each equi-join pair derived table-another table. ... / {code} {code:cpp} / @brief Change references to underlying items of a merged derived table/view for fields in derived table's result table. @return FALSE ok @return TRUE Out of memory */ bool TABLE_LIST::change_refs_to_fields() {code} The first comment is out of place. It should have been at sql_select.cc, generate_derived_keys_for_table().	In current code, we have in table.cc: {code:cpp} /* Procedure of keys generation for result tables of materialized derived tables/views. A key is generated for each equi-join pair derived table-another table. ... / {code} {code:cpp} / @brief Change references to underlying items of a merged derived table/view for fields in derived table's result table. @return FALSE ok @return TRUE Out of memory */ bool TABLE_LIST::change_refs_to_fields() {code} The first comment is out of place. It should have been at sql_select.cc, generate_derived_keys_for_table(). The comment was put there by {code} commit 709a0a131021135e9fb7a2095fcfcbc223dfb126 Author: Igor Babaev <igor@askmonty.org> Date: Wed May 26 13:18:18 2010 -0700 MWL#106: Backport optimizations for derived tables and views. The main consolidated patch. {code}

Sergei Petrunia made changes - 2025-03-25 12:29

Description

In current code, we have in table.cc:

{code:cpp}
/*
  Procedure of keys generation for result tables of materialized derived
  tables/views.

  A key is generated for each equi-join pair derived table-another table.
...
*/
{code}

{code:cpp}
/*
  @brief
  Change references to underlying items of a merged derived table/view
  for fields in derived table's result table.

  @return FALSE ok
  @return TRUE Out of memory
*/
bool TABLE_LIST::change_refs_to_fields()
{code}

The first comment is out of place.
It should have been at sql_select.cc, generate_derived_keys_for_table().

The comment was put there by
{code}
commit 709a0a131021135e9fb7a2095fcfcbc223dfb126
Author: Igor Babaev <igor@askmonty.org>
Date: Wed May 26 13:18:18 2010 -0700

    MWL#106: Backport optimizations for derived tables and views.
    The main consolidated patch.

{code}

In current code, we have in table.cc:

{code:cpp}
/*
  Procedure of keys generation for result tables of materialized derived
  tables/views.

  A key is generated for each equi-join pair derived table-another table.
...
*/
{code}

{code:cpp}
/*
  @brief
  Change references to underlying items of a merged derived table/view
  for fields in derived table's result table.

  @return FALSE ok
  @return TRUE Out of memory
*/
bool TABLE_LIST::change_refs_to_fields()
{code}

The first comment is out of place.
It should have been at sql_select.cc, generate_derived_keys_for_table().

The comment was added in this commit:

{code}
commit 709a0a131021135e9fb7a2095fcfcbc223dfb126
Author: Igor Babaev <igor@askmonty.org>
Date: Wed May 26 13:18:18 2010 -0700

    MWL#106: Backport optimizations for derived tables and views.
    The main consolidated patch.

{code}

generate_derived_keys_for_table() was also introduced in the same commit.

Sergei Petrunia made changes - 2025-03-25 12:42

Description

In current code, we have in table.cc:

{code:cpp}
/*
  Procedure of keys generation for result tables of materialized derived
  tables/views.

  A key is generated for each equi-join pair derived table-another table.
...
*/
{code}

{code:cpp}
/*
  @brief
  Change references to underlying items of a merged derived table/view
  for fields in derived table's result table.

  @return FALSE ok
  @return TRUE Out of memory
*/
bool TABLE_LIST::change_refs_to_fields()
{code}

The first comment is out of place.
It should have been at sql_select.cc, generate_derived_keys_for_table().

The comment was added in this commit:

{code}
commit 709a0a131021135e9fb7a2095fcfcbc223dfb126
Author: Igor Babaev <igor@askmonty.org>
Date: Wed May 26 13:18:18 2010 -0700

    MWL#106: Backport optimizations for derived tables and views.
    The main consolidated patch.

{code}

generate_derived_keys_for_table() was also introduced in the same commit.

In current code, we have in table.cc:

{code:cpp}
/*
  Procedure of keys generation for result tables of materialized derived
  tables/views.

  A key is generated for each equi-join pair derived table-another table.
...
*/
{code}

{code:cpp}
/*
  @brief
  Change references to underlying items of a merged derived table/view
  for fields in derived table's result table.

  @return FALSE ok
  @return TRUE Out of memory
*/
bool TABLE_LIST::change_refs_to_fields()
{code}

The first comment is out of place.
It should have been at sql_select.cc, generate_derived_keys().

The comment was added in this commit:

{code}
commit 709a0a131021135e9fb7a2095fcfcbc223dfb126
Author: Igor Babaev <igor@askmonty.org>
Date: Wed May 26 13:18:18 2010 -0700

    MWL#106: Backport optimizations for derived tables and views.
    The main consolidated patch.

{code}

generate_derived_keys() was also introduced in the same commit.

Sergei Petrunia made changes - 2025-03-25 12:43

Affects Version/s		10.5 [ 23123 ]
Affects Version/s		10.11 [ 27614 ]

Sergei Petrunia made changes - 2025-03-25 12:43

Component/s

Optimizer [ 10200 ]

Sergei Petrunia made changes - 2025-03-25 12:43

Fix Version/s

10.11 [ 27614 ]

Sergei Petrunia made changes - 2025-03-25 12:43

Status

Open [ 1 ]

Confirmed [ 10101 ]

Sergei Petrunia made changes - 2025-03-25 17:09

Assignee

Sergei Petrunia [ psergey ]

Sergei Petrunia made changes - 2025-03-26 08:39

Fix Version/s		10.11.12 [ 29998 ]
Fix Version/s		11.4.6 [ 29999 ]
Fix Version/s		11.8.2 [ 30001 ]
Fix Version/s	10.11 [ 27614 ]
Resolution		Fixed [ 1 ]
Status	Confirmed [ 10101 ]	Closed [ 6 ]

People

Assignee:: Sergei Petrunia

Reporter:: Sergei Petrunia

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 2025-03-25 12:25

Updated:: 2025-04-01 10:52

Resolved:: 2025-03-26 08:39

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Activity

People

Dates

Git Integration