Type:
Bug
Priority:
Critical
Resolution:
Unresolved
Affects Version/s:
12.0
This patch improves libfmt detection by calling find_package(fmt QUIET) first when WITH_LIBFMT is set to system or auto. If a system libfmt is located successfully, we skip the custom source-compile snippet. Otherwise, we proceed with the old detection logic (compile test) and finally fall back to the bundled library if needed. This change makes it easier for package managers (e.g., Homebrew) or system environments that already have a modern fmt installed to integrate with MariaDB, without having to override CMake variables manually.
Before this patch, the logic always set CMAKE_REQUIRED_INCLUDES to the bundled copy’s include directory and ran a snippet test, failing if the user had removed or disabled the bundled directory. Now, if a system installation is discoverable via CMake config files, MariaDB can be built cleanly against that library.
Pull request: https://github.com/MariaDB/server/pull/3786
Sergey Vojtovich
made changes -
2025-03-24 19:47
Field
Original Value
New Value
Status
Open
[ 1
]
Confirmed
[ 10101
]
Sergey Vojtovich
made changes -
2025-03-24 19:48
Assignee
Sergey Vojtovich
[ svoj
]
Sergei Golubchik
[ serg
]
Status
Confirmed
[ 10101
]
In Review
[ 10002
]
Sergei Golubchik
made changes -
2025-03-24 19:57
Priority
Major
[ 3
]
Critical
[ 2
]
Sergei Golubchik
made changes -
2025-03-24 19:57
Fix Version/s
10.11
[ 27614
]
Fix Version/s
12.0
[ 29945
]
{"report":{"fcp":765.3999996185303,"ttfb":174.89999961853027,"pageVisibility":"visible","entityId":133467,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"8a0d6aac-c9b3-4581-aa1a-0234905de53c","navigationType":0,"readyForUser":832.8999996185303,"redirectCount":0,"resourceLoadedEnd":859.8000001907349,"resourceLoadedStart":180.60000038146973,"resourceTiming":[{"duration":11.899999618530273,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":180.60000038146973,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":180.60000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":192.5,"responseStart":0,"secureConnectionStart":0},{"duration":12,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":180.89999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":180.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":192.89999961853027,"responseStart":0,"secureConnectionStart":0},{"duration":67.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":181.10000038146973,"connectEnd":181.10000038146973,"connectStart":181.10000038146973,"domainLookupEnd":181.10000038146973,"domainLookupStart":181.10000038146973,"fetchStart":181.10000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":181.10000038146973,"responseEnd":248.80000019073486,"responseStart":248.80000019073486,"secureConnectionStart":181.10000038146973},{"duration":121.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":181.30000019073486,"connectEnd":181.30000019073486,"connectStart":181.30000019073486,"domainLookupEnd":181.30000019073486,"domainLookupStart":181.30000019073486,"fetchStart":181.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":181.30000019073486,"responseEnd":302.5,"responseStart":302.5,"secureConnectionStart":181.30000019073486},{"duration":125.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":181.5,"connectEnd":181.5,"connectStart":181.5,"domainLookupEnd":181.5,"domainLookupStart":181.5,"fetchStart":181.5,"redirectEnd":0,"redirectStart":0,"requestStart":181.5,"responseEnd":306.69999980926514,"responseStart":306.69999980926514,"secureConnectionStart":181.5},{"duration":125.40000057220459,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":181.69999980926514,"connectEnd":181.69999980926514,"connectStart":181.69999980926514,"domainLookupEnd":181.69999980926514,"domainLookupStart":181.69999980926514,"fetchStart":181.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":181.69999980926514,"responseEnd":307.1000003814697,"responseStart":307.1000003814697,"secureConnectionStart":181.69999980926514},{"duration":130,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":181.80000019073486,"connectEnd":181.80000019073486,"connectStart":181.80000019073486,"domainLookupEnd":181.80000019073486,"domainLookupStart":181.80000019073486,"fetchStart":181.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":181.80000019073486,"responseEnd":311.80000019073486,"responseStart":311.80000019073486,"secureConnectionStart":181.80000019073486},{"duration":212.10000038146973,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":182,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":182,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":394.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":130.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":182.10000038146973,"connectEnd":182.10000038146973,"connectStart":182.10000038146973,"domainLookupEnd":182.10000038146973,"domainLookupStart":182.10000038146973,"fetchStart":182.10000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":182.10000038146973,"responseEnd":312.30000019073486,"responseStart":312.30000019073486,"secureConnectionStart":182.10000038146973},{"duration":212,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":182.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":182.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":394.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":130.70000076293945,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":182.39999961853027,"connectEnd":182.39999961853027,"connectStart":182.39999961853027,"domainLookupEnd":182.39999961853027,"domainLookupStart":182.39999961853027,"fetchStart":182.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":182.39999961853027,"responseEnd":313.1000003814697,"responseStart":313.1000003814697,"secureConnectionStart":182.39999961853027},{"duration":319.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":183.19999980926514,"connectEnd":183.19999980926514,"connectStart":183.19999980926514,"domainLookupEnd":183.19999980926514,"domainLookupStart":183.19999980926514,"fetchStart":183.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":183.19999980926514,"responseEnd":502.8999996185303,"responseStart":502.8999996185303,"secureConnectionStart":183.19999980926514},{"duration":670.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":183.30000019073486,"connectEnd":183.30000019073486,"connectStart":183.30000019073486,"domainLookupEnd":183.30000019073486,"domainLookupStart":183.30000019073486,"fetchStart":183.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":183.30000019073486,"responseEnd":853.5,"responseStart":853.5,"secureConnectionStart":183.30000019073486},{"duration":79.59999942779541,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":424.1000003814697,"connectEnd":424.1000003814697,"connectStart":424.1000003814697,"domainLookupEnd":424.1000003814697,"domainLookupStart":424.1000003814697,"fetchStart":424.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":424.1000003814697,"responseEnd":503.69999980926514,"responseStart":503.69999980926514,"secureConnectionStart":424.1000003814697},{"duration":185.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":674.6000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":674.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":859.8000001907349,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":16,"responseStart":175,"responseEnd":178,"domLoading":179,"domInteractive":882,"domContentLoadedEventStart":882,"domContentLoadedEventEnd":921,"domComplete":1293,"loadEventStart":1293,"loadEventEnd":1294,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":867.8999996185303},{"name":"bigPipe.sidebar-id.end","time":868.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":868.8999996185303},{"name":"bigPipe.activity-panel-pipe-id.end","time":870.6000003814697},{"name":"activityTabFullyLoaded","time":938.6999998092651}],"measures":[],"correlationId":"ffb2cb9a46b0cf","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":106,"dbReadsTimeInMs":16,"dbConnsTimeInMs":24,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}