Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35876

speedup collation/charset lookup

Details

    Description

      currently a collation lookup (collation name to collation id) is done (in get_collation_number_internal()) by linearly scanning the array of collations.

      This used to work fine, but the number of collations is constantly growing (MDEV-27009, MDEV-20912) and the linear search is starting to become noticeable.

      It would be a good idea to change it to a hash lookup.

      Same can be done for character sets, even though the number of charsets didn't grow that much.

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-20912 Add support for utf8mb4_0900_* collations in MariaDB Server

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-27009 Add UCA-14.0.0 collations

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            serg Sergei Golubchik created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Description currently a collation lookup (collation name to collation id) is done (in {{get_collation_number_internal()}}) by linearly scanning the array of collations.

            This used to work fine, but the number of collations is constantly growing (MDEV-27009, MDEV-35256) and the linear search is starting to become noticeable.

            It would be a good idea to change it to a hash lookup.

            Same can be done for character sets, even though the number of charsets didn't grow that much.             		currently a collation lookup (collation name to collation id) is done (in {{get_collation_number_internal()}}) by linearly scanning the array of collations.

            This used to work fine, but the number of collations is constantly growing (MDEV-27009, MDEV-20912) and the linear search is starting to become noticeable.

            It would be a good idea to change it to a hash lookup.

            Same can be done for character sets, even though the number of charsets didn't grow that much.
            ralf.gebhardt Ralf Gebhardt made changes -
            Labels tech_debt
            serg Sergei Golubchik made changes -
            Labels tech_debt beginner-friendly tech_debt
            jitu1511 Jitesh Chawla added a comment -

            Hi Team,
            can I look into this task ?

            jitu1511 Jitesh Chawla added a comment - Hi Team, can I look into this task ?
            serg Sergei Golubchik added a comment -

            of course! please, do, thank you

            serg Sergei Golubchik added a comment - of course! please, do, thank you

            People

              bar Alexander Barkov
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.