Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35746

support fmtlib-11.1.0 (that doesn't have FMT_STATIC_THOUSANDS_SEPARATOR)

Details

    Description

      fmtlib upstream removed the ability to control locale usage via an undocumented FMT_STATIC_THOUSANDS_SEPARATOR in favor of FMT_USE_LOCALE. The issue is related to the commit https://github.com/fmtlib/fmt/commit/b3ccc2d2100052b3a3079941febf2494caa07402. This change makes the mariadb fail to configure with -DWITH_LIBFMT=system when fmtlib 11.1.0 or newer is installed in the system. See also https://bugs.gentoo.org/946924.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-35797 update bundled libfmt to 11.1.1

          • Major - Major loss of function.
          • Open
          links to

          Web Link FMT_STATIC_THOUSANDS_SEPARATOR removed. Alternative?

          Activity

            Ascending order - Click to sort in descending order
            arkamar Petr Vaněk created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Blocker [ 1 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.4 [ 29301 ]
            serg Sergei Golubchik added a comment -

            reported an issue for fmtlib.

            If it's broken temporarily — meaning, if they'll add it back or implement another way of quickly adding thousand separators (perhaps we can override some class or whatever) — then I'll change the server to test for that and fallback to bundled fmtlib if the workaround is not available.

            If it's broken permanently, I suppose, we'll have to remove {:L} support from SFROMAT().

            serg Sergei Golubchik added a comment - reported an issue for fmtlib. If it's broken temporarily — meaning, if they'll add it back or implement another way of quickly adding thousand separators (perhaps we can override some class or whatever) — then I'll change the server to test for that and fallback to bundled fmtlib if the workaround is not available. If it's broken permanently, I suppose, we'll have to remove { :L } support from SFROMAT() .
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Priority Blocker [ 1 ] Major [ 3 ]
            serg Sergei Golubchik added a comment - - edited

            Changing to a feature request, because it's not a bug, the current behavior is correct. System libfmt is unusable (because {:L} doesn't work), cmake correctly detects it and falls back to bundled libfmt.

            We need to do something to support libfmt 11.1+, but the current build behavior is correct.

            serg Sergei Golubchik added a comment - - edited Changing to a feature request, because it's not a bug, the current behavior is correct. System libfmt is unusable (because { :L } doesn't work), cmake correctly detects it and falls back to bundled libfmt. We need to do something to support libfmt 11.1+, but the current build behavior is correct.
            serg Sergei Golubchik made changes -
            Affects Version/s 10.11.10 [ 29904 ]
            Affects Version/s 11.4.4 [ 29907 ]
            Environment Gentoo amd64
            Issue Type Bug [ 1 ] Task [ 3 ]
            serg Sergei Golubchik made changes -
            Summary fmtlib-11.1.0 removed the ability to control locale usage via an undocumented FMT_STATIC_THOUSANDS_SEPARATOR support fmtlib-11.1.0 (that doesn't have FMT_STATIC_THOUSANDS_SEPARATOR)
            arkamar Petr Vaněk added a comment -

            Ok, we are currently limiting libfmt to older versions for mariadb in gentoo package.

            arkamar Petr Vaněk added a comment - Ok, we are currently limiting libfmt to older versions for mariadb in gentoo package.
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            svoj Sergey Vojtovich made changes -
            Labels contribution

            People

              serg Sergei Golubchik
              arkamar Petr Vaněk
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.