Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35683

DYNAMIC_ARRAY lacks basic unit tests

Details

    Description

      The DYNAMIC_ARRAY type ( defined in my_sys.h with code in mysys/array.c ) is still used in hundreds of places in the code, especially in C code which obviously does not have easy access to standard C++ classes.

      However, the testing of this code is indirect testing of DYNAMIC_ARRAY as integrated in the other code.

      By contrast, the DYNAMIC_STRING has unittest/mysys/dynstring-t.c which shows basic usage and tests for basic correctness.

      The absence of a similar test for DYNAMIC_ARRAY seems like an oversight.

      Attachments

        Activity

          Eric_Herman Eric Herman created issue -
          danblack Daniel Black made changes -
          Field Original Value New Value
          Labels beginner-friendly
          serg Sergei Golubchik made changes -
          Assignee Sergei Golubchik [ serg ]
          serg Sergei Golubchik made changes -
          Fix Version/s 11.8 [ 29921 ]
          serg Sergei Golubchik made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          serg Sergei Golubchik made changes -
          Assignee Sergei Golubchik [ serg ] Daniel Black [ danblack ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          danblack Daniel Black added a comment -

          Thanks Eric_Herman!

          danblack Daniel Black added a comment - Thanks Eric_Herman !
          danblack Daniel Black made changes -
          issue.field.resolutiondate 2024-12-20 00:09:01.0 2024-12-20 00:09:01.038
          danblack Daniel Black made changes -
          Component/s Tests [ 10800 ]
          Component/s N/A [ 14411 ]
          Fix Version/s 11.8.1 [ 29961 ]
          Fix Version/s 11.8 [ 29921 ]
          Resolution Fixed [ 1 ]
          Status In Review [ 10002 ] Closed [ 6 ]

          People

            danblack Daniel Black
            Eric_Herman Eric Herman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.