Type:
Task
Priority:
Trivial
Resolution:
Fixed
The DYNAMIC_ARRAY type ( defined in my_sys.h with code in mysys/array.c ) is still used in hundreds of places in the code, especially in C code which obviously does not have easy access to standard C++ classes.
However, the testing of this code is indirect testing of DYNAMIC_ARRAY as integrated in the other code.
By contrast, the DYNAMIC_STRING has unittest/mysys/dynstring-t.c which shows basic usage and tests for basic correctness.
The absence of a similar test for DYNAMIC_ARRAY seems like an oversight.
{"report":{"fcp":740.1000003814697,"ttfb":168.7000002861023,"pageVisibility":"visible","entityId":132119,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"5e607076-cfb1-4670-830f-16beae4fc79e","navigationType":0,"readyForUser":820.8000001907349,"redirectCount":0,"resourceLoadedEnd":462.5,"resourceLoadedStart":178.80000019073486,"resourceTiming":[{"duration":21,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":178.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":178.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":199.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":21,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":179.10000038146973,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":179.10000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":200.10000038146973,"responseStart":0,"secureConnectionStart":0},{"duration":79.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":179.30000019073486,"connectEnd":179.30000019073486,"connectStart":179.30000019073486,"domainLookupEnd":179.30000019073486,"domainLookupStart":179.30000019073486,"fetchStart":179.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":194.30000019073486,"responseEnd":258.40000009536743,"responseStart":215.30000019073486,"secureConnectionStart":179.30000019073486},{"duration":108.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":179.5,"connectEnd":179.5,"connectStart":179.5,"domainLookupEnd":179.5,"domainLookupStart":179.5,"fetchStart":179.5,"redirectEnd":0,"redirectStart":0,"requestStart":199.7000002861023,"responseEnd":288.40000009536743,"responseStart":236.5,"secureConnectionStart":179.5},{"duration":35.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":179.7000002861023,"connectEnd":179.7000002861023,"connectStart":179.7000002861023,"domainLookupEnd":179.7000002861023,"domainLookupStart":179.7000002861023,"fetchStart":179.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":195.40000009536743,"responseEnd":215.10000038146973,"responseStart":214.5,"secureConnectionStart":179.7000002861023},{"duration":34.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":179.90000009536743,"connectEnd":179.90000009536743,"connectStart":179.90000009536743,"domainLookupEnd":179.90000009536743,"domainLookupStart":179.90000009536743,"fetchStart":179.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":195.2000002861023,"responseEnd":214.30000019073486,"responseStart":213.7000002861023,"secureConnectionStart":179.90000009536743},{"duration":56.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":180,"connectEnd":180,"connectStart":180,"domainLookupEnd":180,"domainLookupStart":180,"fetchStart":180,"redirectEnd":0,"redirectStart":0,"requestStart":199.10000038146973,"responseEnd":236.40000009536743,"responseStart":235.7000002861023,"secureConnectionStart":180},{"duration":20.199999809265137,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":180.10000038146973,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":180.10000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":200.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":55,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":180.30000019073486,"connectEnd":213.10000038146973,"connectStart":213.10000038146973,"domainLookupEnd":213.10000038146973,"domainLookupStart":213.10000038146973,"fetchStart":180.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":217.60000038146973,"responseEnd":235.30000019073486,"responseStart":232.2000002861023,"secureConnectionStart":213.10000038146973},{"duration":19.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":180.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":180.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":200.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":92.39999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":180.60000038146973,"connectEnd":180.60000038146973,"connectStart":180.60000038146973,"domainLookupEnd":180.60000038146973,"domainLookupStart":180.60000038146973,"fetchStart":180.60000038146973,"redirectEnd":0,"redirectStart":0,"requestStart":204.2000002861023,"responseEnd":273,"responseStart":261.5,"secureConnectionStart":180.60000038146973},{"duration":259.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":201.90000009536743,"connectEnd":201.90000009536743,"connectStart":201.90000009536743,"domainLookupEnd":201.90000009536743,"domainLookupStart":201.90000009536743,"fetchStart":201.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":285.2000002861023,"responseEnd":461,"responseStart":456.7000002861023,"secureConnectionStart":201.90000009536743},{"duration":260.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":201.90000009536743,"connectEnd":201.90000009536743,"connectStart":201.90000009536743,"domainLookupEnd":201.90000009536743,"domainLookupStart":201.90000009536743,"fetchStart":201.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":289.7000002861023,"responseEnd":462.5,"responseStart":458.90000009536743,"secureConnectionStart":201.90000009536743},{"duration":216.30000019073486,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":485.40000009536743,"connectEnd":485.40000009536743,"connectStart":485.40000009536743,"domainLookupEnd":485.40000009536743,"domainLookupStart":485.40000009536743,"fetchStart":485.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":661.3000001907349,"responseEnd":701.7000002861023,"responseStart":701,"secureConnectionStart":485.40000009536743},{"duration":122.69999980926514,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":729.2000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":729.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":851.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":129.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":758.4000000953674,"connectEnd":758.4000000953674,"connectStart":758.4000000953674,"domainLookupEnd":758.4000000953674,"domainLookupStart":758.4000000953674,"fetchStart":758.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":842.9000000953674,"responseEnd":888.3000001907349,"responseStart":883.8000001907349,"secureConnectionStart":758.4000000953674}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":30,"responseStart":168,"responseEnd":183,"domLoading":172,"domInteractive":876,"domContentLoadedEventStart":876,"domContentLoadedEventEnd":927,"domComplete":1154,"loadEventStart":1154,"loadEventEnd":1155,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":853.7000002861023},{"name":"bigPipe.sidebar-id.end","time":856},{"name":"bigPipe.activity-panel-pipe-id.start","time":856.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.end","time":857.1000003814697},{"name":"activityTabFullyLoaded","time":949.4000000953674}],"measures":[],"correlationId":"d8c30dc9239b49","effectiveType":"4g","downlink":9.5,"rtt":0,"serverDuration":85,"dbReadsTimeInMs":10,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Thanks Eric_Herman!