Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35672

unittest output from json_normalize-t is unclear

Details

    • Task
    • Status: Closed (View Workflow)
    • Trivial
    • Resolution: Fixed
    • 11.8.1
    • Tests
    • None

    Description

      The results from running build/unittest/json_lib/json_normalize-t could be more clear.

      For example:

      ok 73 - normalize err?
      		 
      ok 74 - expected '{"foo":"value"}' from '{
      		 
        "foo": "value"
      		 
      }
      		 
      ' but was '{"foo":"value"}'

      There are two problems:

      1) the TAP context strings are worded such that they only make sense in the failure case, not the (far more likely) success case

      2) the input, expected, and actual results are not aligned to make it visiable at a glance if they match or not.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          Eric_Herman Eric Herman created issue -
          Eric_Herman Eric Herman added a comment -

          I'm sorry. I don't know how I goofed this, but it seems when I tried to create an issue, it created as a Column-Store issue:

          https://jira.mariadb.org/browse/MCOL-5872

          I also don't see how I can change it. Can someone please help me move this to be an MDEV ?

          Eric_Herman Eric Herman added a comment - I'm sorry. I don't know how I goofed this, but it seems when I tried to create an issue, it created as a Column-Store issue: https://jira.mariadb.org/browse/MCOL-5872 I also don't see how I can change it. Can someone please help me move this to be an MDEV ?
          Gosselin Dave Gosselin made changes -
          Field Original Value New Value
          Component/s mtr [ 16827 ]
          Key MCOL-5872 MDBF-867
          Affects Version/s N/A [ 27305 ]
          Affects Version/s N/A [ 24311 ]
          Workflow MariaDB ColumnStore workflow [ 187718 ] MariaDB v4 [ 187719 ]
          Project MariaDB ColumnStore [ 10902 ] MariaDB Foundation Development [ 11901 ]
          Gosselin Dave Gosselin made changes -
          Key MDBF-867 MDEV-35672
          Affects Version/s N/A [ 27305 ]
          Environment Developer running unit tests locally
          Project MariaDB Foundation Development [ 11901 ] MariaDB Server [ 10000 ]
          Eric_Herman Eric Herman added a comment -

          Thank you, Dave!

          Eric_Herman Eric Herman added a comment - Thank you, Dave!
          Eric_Herman Eric Herman added a comment -

          https://github.com/MariaDB/server/pull/3711

          Eric_Herman Eric Herman added a comment - https://github.com/MariaDB/server/pull/3711
          danblack Daniel Black made changes -
          Assignee Daniel Black [ danblack ]
          danblack Daniel Black made changes -
          Fix Version/s 11.8.1 [ 29961 ]
          danblack Daniel Black made changes -
          issue.field.resolutiondate 2024-12-17 23:13:16.0 2024-12-17 23:13:15.792
          danblack Daniel Black made changes -
          Component/s Tests [ 10800 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]

          People

            danblack Daniel Black
            Eric_Herman Eric Herman
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.