Type:
Task
Priority:
Trivial
Resolution:
Unresolved
Fix Version/s:
None
Component/s:
None
The difference between literal-`%s` and %sQ is that the latter also “escapes” ` ’s into `` ’s.
Not all my_vsnprintf uses make use of this failsafe.
Messages that prompt SQL content (e.g., database identifiers) should use %sQ ’s so the quote is copy-pastable as-is.
As MDEV-21978 updates, its Part 2 PR will make a list of my_vsnprintf -delegating functions visible from its changed files .
I’ve marked MDEV-21978 as blocking this anyway as it adds %sQ (that deprecates the old %`s ), available in preview soon™.
Markdown formats back`tick as ``back`tick`` , but I don’t think we care about those.
is blocked by
MDEV-21978
make my_vsnprintf to use gcc-compatible format extensions
Closed
Jimmy Hú
created issue -
2024-12-08 20:26
Jimmy Hú
made changes -
2024-12-08 20:27
Description
The difference between literal-{{`%s`}} and {{%sQ}} is that the latter also “escapes” {{`}}’s into {{``}}’s.
Not all {{my_vsnprintf}} uses make use of this failsafe.
Messages that prompt SQL content (e.g., database identifiers) should use {{%sQ}}’s so the quote is copy-pastable as-is.
As MDEV-21978 updates, its PR will make a list of {{my_vsnprintf}}-delegating functions visible from [its changed files|https://github.com/MariaDB/server/pull/3360/files ].
I’ve marked MDEV-21978 as blocking this anyway as it adds {{%sQ}} (that deprecates the old {{%`s}}), available in preview soon™.
Markdown formats {{back`tick}} as {{``back`tick``}}, but I don’t think we care about those.
The difference between literal-{{`%s`}} and {{%sQ}} is that the latter also “escapes” {{`}}’s into {{``}}’s.
Not all {{my_vsnprintf}} uses make use of this failsafe.
Messages that prompt SQL content (e.g., database identifiers) should use {{%sQ}}’s so the quote is copy-pastable as-is.
As MDEV-21978 updates, its Part 2 PR will make a list of {{my_vsnprintf}}-delegating functions visible from [its changed files|https://github.com/MariaDB/server/pull/3360/files ].
I’ve marked MDEV-21978 as blocking this anyway as it adds {{%sQ}} (that deprecates the old {{%`s}}), available in preview soon™.
Markdown formats {{back`tick}} as {{``back`tick``}}, but I don’t think we care about those.
Ralf Gebhardt
made changes -
2024-12-10 08:32
Issue Type
New Feature
[ 2
]
Task
[ 3
]
{"report":{"fcp":1026.3000001907349,"ttfb":238.30000019073486,"pageVisibility":"visible","entityId":131954,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"04e40057-e5ba-4bb9-abb5-d3f89454973b","navigationType":0,"readyForUser":1086.8000001907349,"redirectCount":0,"resourceLoadedEnd":1275.3000001907349,"resourceLoadedStart":243.5,"resourceTiming":[{"duration":267.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":243.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":243.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":511,"responseStart":0,"secureConnectionStart":0},{"duration":267.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":243.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":243.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":511.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":276.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":243.90000009536743,"connectEnd":243.90000009536743,"connectStart":243.90000009536743,"domainLookupEnd":243.90000009536743,"domainLookupStart":243.90000009536743,"fetchStart":243.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":243.90000009536743,"responseEnd":520.3000001907349,"responseStart":520.3000001907349,"secureConnectionStart":243.90000009536743},{"duration":319.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":244.10000014305115,"connectEnd":244.10000014305115,"connectStart":244.10000014305115,"domainLookupEnd":244.10000014305115,"domainLookupStart":244.10000014305115,"fetchStart":244.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":244.10000014305115,"responseEnd":563.3000001907349,"responseStart":563.3000001907349,"secureConnectionStart":244.10000014305115},{"duration":322.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":244.30000019073486,"connectEnd":244.30000019073486,"connectStart":244.30000019073486,"domainLookupEnd":244.30000019073486,"domainLookupStart":244.30000019073486,"fetchStart":244.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":244.30000019073486,"responseEnd":566.5,"responseStart":566.5,"secureConnectionStart":244.30000019073486},{"duration":323,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":244.5,"connectEnd":244.5,"connectStart":244.5,"domainLookupEnd":244.5,"domainLookupStart":244.5,"fetchStart":244.5,"redirectEnd":0,"redirectStart":0,"requestStart":244.5,"responseEnd":567.5,"responseStart":567.5,"secureConnectionStart":244.5},{"duration":323.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":244.60000014305115,"connectEnd":244.60000014305115,"connectStart":244.60000014305115,"domainLookupEnd":244.60000014305115,"domainLookupStart":244.60000014305115,"fetchStart":244.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":244.60000014305115,"responseEnd":568.1000001430511,"responseStart":568.1000001430511,"secureConnectionStart":244.60000014305115},{"duration":421.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":244.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":244.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":666.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":324,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":245.10000014305115,"connectEnd":245.10000014305115,"connectStart":245.10000014305115,"domainLookupEnd":245.10000014305115,"domainLookupStart":245.10000014305115,"fetchStart":245.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":245.10000014305115,"responseEnd":569.1000001430511,"responseStart":569.1000001430511,"secureConnectionStart":245.10000014305115},{"duration":421.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":245.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":245.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":667,"responseStart":0,"secureConnectionStart":0},{"duration":324.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":245.40000009536743,"connectEnd":245.40000009536743,"connectStart":245.40000009536743,"domainLookupEnd":245.40000009536743,"domainLookupStart":245.40000009536743,"fetchStart":245.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":245.40000009536743,"responseEnd":569.7000000476837,"responseStart":569.7000000476837,"secureConnectionStart":245.40000009536743},{"duration":989.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":250.90000009536743,"connectEnd":250.90000009536743,"connectStart":250.90000009536743,"domainLookupEnd":250.90000009536743,"domainLookupStart":250.90000009536743,"fetchStart":250.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":250.90000009536743,"responseEnd":1240,"responseStart":1240,"secureConnectionStart":250.90000009536743},{"duration":990.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":251.10000014305115,"connectEnd":251.10000014305115,"connectStart":251.10000014305115,"domainLookupEnd":251.10000014305115,"domainLookupStart":251.10000014305115,"fetchStart":251.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":251.10000014305115,"responseEnd":1241.7000000476837,"responseStart":1241.7000000476837,"secureConnectionStart":251.10000014305115},{"duration":229.09999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":695.3000001907349,"connectEnd":695.3000001907349,"connectStart":695.3000001907349,"domainLookupEnd":695.3000001907349,"domainLookupStart":695.3000001907349,"fetchStart":695.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":695.3000001907349,"responseEnd":924.4000000953674,"responseStart":924.4000000953674,"secureConnectionStart":695.3000001907349},{"duration":314.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":961.1000001430511,"connectEnd":961.1000001430511,"connectStart":961.1000001430511,"domainLookupEnd":961.1000001430511,"domainLookupStart":961.1000001430511,"fetchStart":961.1000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":961.1000001430511,"responseEnd":1275.3000001907349,"responseStart":1275.3000001907349,"secureConnectionStart":961.1000001430511}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":27,"responseStart":238,"responseEnd":247,"domLoading":242,"domInteractive":1301,"domContentLoadedEventStart":1301,"domContentLoadedEventEnd":1346,"domComplete":1649,"loadEventStart":1649,"loadEventEnd":1649,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1244.2000000476837},{"name":"bigPipe.sidebar-id.end","time":1245},{"name":"bigPipe.activity-panel-pipe-id.start","time":1245.1000001430511},{"name":"bigPipe.activity-panel-pipe-id.end","time":1247.1000001430511},{"name":"activityTabFullyLoaded","time":1360.1000001430511}],"measures":[],"correlationId":"21c5983821106e","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":125,"dbReadsTimeInMs":13,"dbConnsTimeInMs":23,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
%iE might have a similar case.