Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35574

remove pthread_exit calls that caused msan/libc++ clang19 problems

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.5.28
    • Server
    • None

    Description

      pthread_exit seems to have been adopted as some trend in the early days of glibc 2.2.5 based on https://bugs.mysql.com/bug.php?id=82886 and the dates of initial pthread_exit call inclusions.

      These seem to have been copied without much consideration.

      This task takes a bit of debt back and just leaves our threads to exit, with the args that where being provided to pthread_exit,

      This backports the removal and cleanup performed in the 11.4 merge - 2719cc4925c032f483edb0e61c0f487e0c429ae6

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          danblack Daniel Black created issue -
          danblack Daniel Black made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          danblack Daniel Black made changes -
          Assignee Daniel Black [ danblack ] Marko Mäkelä [ marko ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          serg Sergei Golubchik added a comment -

          what's wrong with using pthread_exit()? it's not documented as obsolete, why should it be removed?

          serg Sergei Golubchik added a comment - what's wrong with using pthread_exit() ? it's not documented as obsolete, why should it be removed?
          marko Marko Mäkelä added a comment -

          Thank you, the removal looks good to me.

          Something appears to be wrong when using clang++ -stdlib=libc++ in Clang 19, as I had noted in MDEV-20377 back in September 2024. Removing the redundant pthread_exit() calls fixes that.

          marko Marko Mäkelä added a comment - Thank you, the removal looks good to me. Something appears to be wrong when using clang++ -stdlib=libc++ in Clang 19, as I had noted in MDEV-20377 back in September 2024. Removing the redundant pthread_exit() calls fixes that.
          marko Marko Mäkelä made changes -
          Assignee Marko Mäkelä [ marko ] Daniel Black [ danblack ]
          Status In Review [ 10002 ] Stalled [ 10000 ]
          danblack Daniel Black made changes -
          Summary remove obsolete pthread_exit calls remove pthread_exit calls that caused msan/libstdc++ clang19 problems
          danblack Daniel Black made changes -
          Fix Version/s 10.5.28 [ 29952 ]
          Fix Version/s 10.5 [ 23123 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]
          marko Marko Mäkelä made changes -
          Summary remove pthread_exit calls that caused msan/libstdc++ clang19 problems remove pthread_exit calls that caused msan/libc++ clang19 problems

          People

            danblack Daniel Black
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.