Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21978 make my_vsnprintf to use gcc-compatible format extensions
  3. MDEV-35434

my_snprintf fixes for 11.5+: missing LEX_STRING::str calls in my_snprintf uses

Details

    • Technical task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 11.5.2
    • 11.7.2
    • Compiling
    • None

    Description

      MDEV-21978 found many erroneous my_snprintf formattings when it reenabled GCC printf checks.
      Patches to these errors should apply to the oldest applicable version in maintenance and up.

      In MariaDB 11.5, the following strings did not fetch .str on their LEX_STRING fields, and so may display them corrupted depending on the compiler and platform, such as Visual Studio:

      Missed by fd247cc21f (MDEV-31340)

      • (DBUG) Wrong max day name(or month name) length for locale: <name>
      • Can't process error message file for locale '<name>'

      other

      • Warning: Enabling keys got errno <error code> on <file name>, retrying (from d2304554ac (MDEV-33751))

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-31340 Remove MY_COLLATION_HANDLER::strcasecmp()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33751 Assertion `thd' failed in int temp_file_size_cb_func(tmp_file_tracking*, int)

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            ParadoxV5 Jimmy Hú created issue -
            ParadoxV5 Jimmy Hú made changes -
            Field Original Value New Value
            ParadoxV5 Jimmy Hú made changes -
            ParadoxV5 Jimmy Hú added a comment -

            https://github.com/MariaDB/server/pull/3538

            ParadoxV5 Jimmy Hú added a comment - https://github.com/MariaDB/server/pull/3538
            danblack Daniel Black made changes -
            Affects Version/s 11.5.2 [ 29838 ]
            Affects Version/s 10.5 [ 23123 ]
            danblack Daniel Black made changes -
            Fix Version/s 11.6 [ 29515 ]
            danblack Daniel Black made changes -
            Assignee Daniel Black [ danblack ]
            danblack Daniel Black made changes -
            Component/s Compiling [ 11001 ]
            Fix Version/s 11.7.2 [ 29914 ]
            Fix Version/s 11.6 [ 29515 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]

            People

              danblack Daniel Black
              ParadoxV5 Jimmy Hú
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.