Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35088

main.timezone started failing in Debian on MEST vs CET time zone difference

Details

    Description

      Recent builds on the official Debian CI system started failing because the time zone in main.timezone changes. I don't know why it changed, and if it is a legit change or not. This upstream bug report is an ask to assess if the current hard-coded time zone value in the test makes sense or not.

      main.timezone                            w4 [ fail ]
              Test ended at 2024-10-06 06:28:50
      CURRENT_TEST: main.timezone
      --- /usr/share/mariadb/mariadb-test/main/timezone.result	2024-08-20 03:41:36.000000000 +0200
      +++ /tmp/tmp.XgWRvorQ7g/var/4/log/timezone.reject	2024-10-06 08:28:49.819975055 +0200
      @@ -1,6 +1,6 @@
       show variables like "system_time_zone";
       Variable_name	Value
      -system_time_zone	MET
      +system_time_zone	CEST
       #
       # Test unix timestamp
       #
      @@ -82,7 +82,7 @@
       SET @@time_zone= default;
       SELECT DATE_FORMAT('2009-11-01 22:23:00', '%z %Z') AS current_timezone;
       current_timezone
      -+0100 MET
      ++0100 CET
       SELECT DATE_FORMAT('2008-06-04 02:23:00', '%z %Z') AS current_timezone;
       current_timezone
      -+0200 MEST
      ++0200 CEST
      Result length mismatch
      

      See failures in action at e.g.
      https://ci.debian.net/packages/m/mariadb/
      -> https://ci.debian.net/packages/m/mariadb/unstable/amd64/52663812/#S14
      https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/mariadb.html
      -> https://tests.reproducible-builds.org/debian/rbuild/unstable/amd64/mariadb_11.4.3-1.rbuild.log.gz
      https://salsa.debian.org/mariadb-team/mariadb-server/-/pipelines
      -> https://salsa.debian.org/mariadb-team/mariadb-server/-/jobs/6245904

      Attachments

        Activity

          danblack Daniel Black added a comment -

          from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084293#30

          > Hi. The relevant changes are in the tzdata package.
          > This is from the changelog:
          >
          > * Upstream obsoleted the System V names CET, CST6CDT, EET, EST*, HST, MET,
          > MST*, PST8PDT, and WET. They are symlinks now. Move those zones to
          > tzdata-legacy and update /etc/localtime on package update to the new names.
          > Please use Etc/GMT* in case you want to avoid DST changes.

          danblack Daniel Black added a comment - from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084293#30 > Hi. The relevant changes are in the tzdata package. > This is from the changelog: > > * Upstream obsoleted the System V names CET, CST6CDT, EET, EST*, HST, MET, > MST*, PST8PDT, and WET. They are symlinks now. Move those zones to > tzdata-legacy and update /etc/localtime on package update to the new names. > Please use Etc/GMT* in case you want to avoid DST changes.

          good find! could you please update the test to not use legacy names?

          serg Sergei Golubchik added a comment - good find! could you please update the test to not use legacy names?
          danblack Daniel Black added a comment -

          Wasn't trigger-able in mtr from a build because mtr overwrote TZ environment variable.

          Added option in timezone.opt.

          https://github.com/MariaDB/server/pull/3621

          danblack Daniel Black added a comment - Wasn't trigger-able in mtr from a build because mtr overwrote TZ environment variable. Added option in timezone.opt. https://github.com/MariaDB/server/pull/3621
          otto Otto Kekäläinen added a comment - - edited

          A fix suggestion and patch was posted in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084293

          otto Otto Kekäläinen added a comment - - edited A fix suggestion and patch was posted in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084293
          danblack Daniel Black added a comment -

          fixed.

          Sorry only noticed the debian patch too late. Good to know it was roughly the same.

          Test case main.timezone will need to be re-recorded in 11.4 where MDEV-31684 added a test that returns CET/CEST respectively.

          danblack Daniel Black added a comment - fixed. Sorry only noticed the debian patch too late. Good to know it was roughly the same. Test case main.timezone will need to be re-recorded in 11.4 where MDEV-31684 added a test that returns CET/CEST respectively.

          People

            danblack Daniel Black
            otto Otto Kekäläinen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.