Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34937

s3 engine no longer functional on non-gcc builds

Details

    Description

      Masking out gcc warnings in https://github.com/mariadb-corporation/libmarias3/commit/5e6aa32f96ebdbcaf32b90d6182685156f8198b5 also masked out the implementation so it would only work on gcc.

      There needs to be a snprintf for non-gcc implementations.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34867 engine S3 cause 500 error for huawei buckets

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            danblack Daniel Black added a comment -

            Proper fix for review: https://github.com/mariadb-corporation/libmarias3/pull/130

            No gcc warnings:

            $ gcc -DHAVE_CONFIG_H -DMYSQL_DYNAMIC_PLUGIN -DWITH_S3_STORAGE_ENGINE -D_FILE_OFFSET_BITS=64 -Ds3_EXPORTS -I/home/dan/repos/mariadb-server-10.6/wsrep-lib/include -I/home/dan/repos/mariadb-server-10.6/wsrep-lib/wsrep-API/v26 -I/home/dan/repos/build-mariadb-server-10.6-gcc/include -I/home/dan/repos/mariadb-server-10.6/include -I/home/dan/repos/mariadb-server-10.6/sql -I/home/dan/repos/mariadb-server-10.6/storage/maria/libmarias3 -Wall  -Werror -pie -fPIC -fstack-protector --param=ssp-buffer-size=4 -O2 -g -DNDEBUG  -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wextra -std=gnu99 -fPIC -MD -MT storage/maria/CMakeFiles/s3.dir/libmarias3/src/assume_role.c.o -MF storage/maria/CMakeFiles/s3.dir/libmarias3/src/assume_role.c.o.d -o storage/maria/CMakeFiles/s3.dir/libmarias3/src/assume_role.c.o -c /home/dan/repos/mariadb-server-10.6/storage/maria/libmarias3/src/assume_role.c
            		 
             
            		 
             
            		 
            $ gcc --version
            		 
            gcc (GCC) 14.2.1 20240801 (Red Hat 14.2.1-1)
            		 
            Copyright (C) 2024 Free Software Foundation, Inc.
            		 
            This is free software; see the source for copying conditions.  There is NO
            		 
            warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

            danblack Daniel Black added a comment - Proper fix for review: https://github.com/mariadb-corporation/libmarias3/pull/130 No gcc warnings: $ gcc -DHAVE_CONFIG_H -DMYSQL_DYNAMIC_PLUGIN -DWITH_S3_STORAGE_ENGINE -D_FILE_OFFSET_BITS=64 -Ds3_EXPORTS -I/home/dan/repos/mariadb-server-10.6/wsrep-lib/include -I/home/dan/repos/mariadb-server-10.6/wsrep-lib/wsrep-API/v26 -I/home/dan/repos/build-mariadb-server-10.6-gcc/include -I/home/dan/repos/mariadb-server-10.6/include -I/home/dan/repos/mariadb-server-10.6/sql -I/home/dan/repos/mariadb-server-10.6/storage/maria/libmarias3 -Wall -Werror -pie -fPIC -fstack-protector --param=ssp-buffer-size=4 -O2 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wextra -std=gnu99 -fPIC -MD -MT storage/maria/CMakeFiles/s3.dir/libmarias3/src/assume_role.c.o -MF storage/maria/CMakeFiles/s3.dir/libmarias3/src/assume_role.c.o.d -o storage/maria/CMakeFiles/s3.dir/libmarias3/src/assume_role.c.o -c /home/dan/repos/mariadb-server-10.6/storage/maria/libmarias3/src/assume_role.c     $ gcc --version gcc (GCC) 14.2.1 20240801 (Red Hat 14.2.1-1) Copyright (C) 2024 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
            danblack Daniel Black added a comment -

            And Server change: https://github.com/MariaDB/server/pull/3554

            danblack Daniel Black added a comment - And Server change: https://github.com/MariaDB/server/pull/3554

            People

              danblack Daniel Black
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.