Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34817

perfschema.lowercase_fs_off fails on buildbot

Details

    • Bug
    • Status: Stalled (View Workflow)
    • Major
    • Resolution: Unresolved
    • 11.5(EOL), 11.6(EOL)
    • 11.8
    • Tests
    • None

    Description

      The MTR test perfschema.lowercase_fs_off fails on buildbot on versions 11.5 and 11.6:

      perfschema.lowercase_fs_off              w17 [ fail ]
              Test ended at 2024-08-21 14:29:23
       
      CURRENT_TEST: perfschema.lowercase_fs_off
      --- /home/buildbot/amd64-ubuntu-2004-debug/build/mysql-test/suite/perfschema/r/lowercase_fs_off.result	2024-08-21 13:50:51.000000000 +0000
      +++ /home/buildbot/amd64-ubuntu-2004-debug/build/mysql-test/suite/perfschema/r/lowercase_fs_off.reject	2024-08-21 14:29:22.909135156 +0000
      @@ -16,6 +16,7 @@
       FROM performance_schema.events_statements_summary_by_program
       WHERE object_type='procedure' AND LOWER(object_schema)='db1';
       object_type	object_schema	object_name	count_star	count_statements	sum_rows_sent
      +PROCEDURE	db1	pkg1.p1	2	2	2
       PROCEDURE	DB1	sp	1	1	1
       PROCEDURE	db1	sp	1	1	1
       DROP DATABASE db1;
       
      Result length mismatch
       
       - saving '/home/buildbot/amd64-ubuntu-2004-debug/build/mysql-test/var/17/log/perfschema.lowercase_fs_off/' to '/home/buildbot/amd64-ubuntu-2004-debug/build/mysql-test/var/log/perfschema.lowercase_fs_off/'
       
      Retrying test perfschema.lowercase_fs_off, attempt(2/3)...
      

      Attachments

        Issue Links

          Activity

            bar Alexander Barkov added a comment - - edited

            The problem happens because when a package procedure (or a package function) is executed, performance schema remembers it as:

            type='procedure'
            db='db'
            name='pkg1.p1'
            

            When a DROP DATABASE happens, performance schema removes from its cached only a record like this:

            type='package body'
            db='db'
            name='pkg1'
            

            To make it work properly, when removing a package body from the perfschema cache, it should parse the package body and remove its all routines.
            This looks quite complex.

            Another option is to remember package routines in perfschema as their owner package body. So when db.pkg1.p1 is executed, perfschema remembers it as:

            type='package body'
            db='db'
            name='pkg1'
            

            But this will worsen the statistics.

            bar Alexander Barkov added a comment - - edited The problem happens because when a package procedure (or a package function) is executed, performance schema remembers it as: type='procedure' db='db' name='pkg1.p1' When a DROP DATABASE happens, performance schema removes from its cached only a record like this: type='package body' db='db' name='pkg1' To make it work properly, when removing a package body from the perfschema cache, it should parse the package body and remove its all routines. This looks quite complex. Another option is to remember package routines in perfschema as their owner package body. So when db.pkg1.p1 is executed, perfschema remembers it as: type='package body' db='db' name='pkg1' But this will worsen the statistics.
            danblack Daniel Black added a comment -

            https://buildbot.mariadb.org/#/builders/534/builds/23551 (main)

            CURRENT_TEST: perfschema.lowercase_fs_off
            --- /home/buildbot/amd64-ubuntu-2204-debug-ps/build/mysql-test/suite/perfschema/r/lowercase_fs_off.result	2024-12-14 12:15:59.000000000 +0000
            +++ /home/buildbot/amd64-ubuntu-2204-debug-ps/build/mysql-test/suite/perfschema/r/lowercase_fs_off.reject	2024-12-14 12:27:47.236326902 +0000
            @@ -16,7 +16,7 @@
             FROM performance_schema.events_statements_summary_by_program
             WHERE object_type='procedure' AND LOWER(object_schema)='m33020_db1';
             object_type	object_schema	object_name	count_star	count_statements	sum_rows_sent
            -PROCEDURE	m33020_DB1	sp	1	1	1
            -PROCEDURE	m33020_db1	sp	1	1	1
            +PROCEDURE	m33020_DB1	sp	2	2	1
            +PROCEDURE	m33020_db1	sp	2	2	1
             DROP DATABASE m33020_db1;
             DROP DATABASE m33020_DB1;
            

            danblack Daniel Black added a comment - https://buildbot.mariadb.org/#/builders/534/builds/23551 (main) CURRENT_TEST: perfschema.lowercase_fs_off --- /home/buildbot/amd64-ubuntu-2204-debug-ps/build/mysql-test/suite/perfschema/r/lowercase_fs_off.result 2024-12-14 12:15:59.000000000 +0000 +++ /home/buildbot/amd64-ubuntu-2204-debug-ps/build/mysql-test/suite/perfschema/r/lowercase_fs_off.reject 2024-12-14 12:27:47.236326902 +0000 @@ -16,7 +16,7 @@ FROM performance_schema.events_statements_summary_by_program WHERE object_type='procedure' AND LOWER(object_schema)='m33020_db1'; object_type object_schema object_name count_star count_statements sum_rows_sent -PROCEDURE m33020_DB1 sp 1 1 1 -PROCEDURE m33020_db1 sp 1 1 1 +PROCEDURE m33020_DB1 sp 2 2 1 +PROCEDURE m33020_db1 sp 2 2 1 DROP DATABASE m33020_db1; DROP DATABASE m33020_DB1;
            ycp Yuchen Pei added a comment -

            Not sure how this can be reproduced locally, not with the old trick of --no-reorder, i.e. the following passes at f5821aaf7731e1f74b970fdaf186b945ae012c9d despite failing in the previous buildbot link, with or without --ps-protocol:

            mtr --no-reorder perfschema.information_schema perfschema.lowercase_fs_off

            This was from August and looks like the same failure
            https://buildbot.mariadb.org/#/builders/572/builds/12277

            ycp Yuchen Pei added a comment - Not sure how this can be reproduced locally, not with the old trick of --no-reorder, i.e. the following passes at f5821aaf7731e1f74b970fdaf186b945ae012c9d despite failing in the previous buildbot link, with or without --ps-protocol: mtr --no-reorder perfschema.information_schema perfschema.lowercase_fs_off This was from August and looks like the same failure https://buildbot.mariadb.org/#/builders/572/builds/12277
            ycp Yuchen Pei added a comment -
            ycp Yuchen Pei added a comment - Just encountered the new failure in https://buildbot.mariadb.org/#/builders/369/builds/27641
            ycp Yuchen Pei added a comment - The latest failure on 11.8 on the new buildbot is from 2025-02-17 59ad3225ae16b5672f10f30841ef414a8cb0d42c: https://buildbot.mariadb.org/#/builders/572/builds/16691 cross ref could not find anything on the old buildbot: https://buildbot.mariadb.net/ci/reports/cross_reference#branch=11.8&revision=&platform=&fail_name=perfschema.lowercase_fs_off&fail_variant=&fail_info_full=&typ=&info=&dt=&limit=100&fail_info_short=

            People

              bar Alexander Barkov
              bnestere Brandon Nesterenko
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.