Details
-
Bug
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
10.11.8, 10.6.18, 11.0.6, 11.1.5, 11.2.4, 11.4.2
Description
MDEV-33613 eliminated page flush from LRU by session thread ( ) when no free pages are found in LRU. The configuration innodb_lru_flush_size used to control the number of pages to be flushed also got unused.
buf_block_t *buf_LRU_get_free_block(bool have_mutex)
|
{
|
...
|
if (!buf_flush_LRU(innodb_lru_flush_size, true)) {
|
MONITOR_INC(MONITOR_LRU_SINGLE_FLUSH_FAILURE_COUNT);
|
++flush_failures;
|
}
|
Based on discussion with marko, we can deprecate the parameter and eventually remove.
Attachments
Issue Links
- causes
-
-
- Closed
-
- is caused by
-
-
- Closed
-
Activity
serg said during a call that we should set the PLUGIN_VAR_DEPRECATED flag for this parameter. But, if we did that, no warning would be written to the server error log if the startup option was used. MDEV-28671 in MariaDB Server 11.5 might fix that, but that would not help users of the 10.6, 10.11 and 11.4 long-term-support releases.
A further suggestion was to additionally set the PLUGIN_VAR_NOCMDOPT flag as well as to declare the parameter as MARIADB_REMOVED_OPTION. That will cause a warning to be emitted if the parameter is present in the startup configuration.
I think that we must not only deprecate the parameter but also change the documentation to note that the parameter has no effect.
As far as I understand, we could simply redefine the parameter as MARIADB_REMOVED_OPTION, so that in case the parameter is specified in the server configuration, the server will be able to start up.
If we didn’t ignore the parameter, following the deprecation procedure would make more sense.