Ramesh Sivaraman added a comment - 2024-07-22 11:33 psergei Found one crash with a different assertion, but I think the root cause of this crash is similar to this issue. Could you please check it? CREATE TABLE t (a DATETIME); SET optimizer_switch= 'derived_merge=off' ; SELECT * FROM ( SELECT * FROM t) AS t WHERE a= '' ; Leads to: 10.5.26 9dafde575f0f91a25d0357c060c311a098c1a737 (Debug) mariadbd: /test/10.5_dbg/sql/item.h:1677: Item* Item::get_copy(THD*) const: Assertion `typeid(*copy) == typeid(*this)' failed. 10.5.26 9dafde575f0f91a25d0357c060c311a098c1a737 (Debug) Core was generated by `/test/MD180724-mariadb-10.5.26-linux-x86_64-dbg/bin/mariadbd --no-defaults --ma'. Program terminated with signal SIGABRT, Aborted. #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 [Current thread is 1 (Thread 0x14ad5cd09700 (LWP 2745152))] (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x000014ad73414859 in __GI_abort () at abort.c:79 #2 0x000014ad73414729 in __assert_fail_base (fmt=0x14ad735aa588 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x557d48f936d0 "typeid(*copy) == typeid(*this)", file=0x557d48f93308 "/test/10.5_dbg/sql/item.h", line=1677, function=<optimized out>) at assert.c:92 #3 0x000014ad73425fd6 in __GI___assert_fail (assertion=assertion@entry=0x557d48f936d0 "typeid(*copy) == typeid(*this)", file=file@entry=0x557d48f93308 "/test/10.5_dbg/sql/item.h", line=line@entry=1677, function=function@entry=0x557d48f936a8 "Item* Item::get_copy(THD*) const") at assert.c:101 #4 0x0000557d48536a1c in Item::get_copy (thd=<optimized out>, this=0x14ad00017788) at /test/10.5_dbg/sql/item.h:1677 #5 Item_datetime_literal::do_build_clone (this=0x14ad00017788, thd=<optimized out>) at /test/10.5_dbg/sql/item.h:5195 #6 0x0000557d485aec1d in Item::build_clone (thd=0x14ad00000d48, this=0x14ad00017788) at /test/10.5_dbg/sql/item.h:1691 #7 Item_equal::create_pushable_equalities (this=this@entry=0x14ad00017840, thd=thd@entry=0x14ad00000d48, equalities=equalities@entry=0x14ad5cd075e0, checker=<optimized out>, arg=arg@entry=0x14ad00067440 "\001", clone_const=true) at /test/10.5_dbg/sql/item_cmpfunc.cc:7822 #8 0x0000557d4857c8b8 in Item::build_pushable_cond (this=this@entry=0x14ad00017840, thd=thd@entry=0x14ad00000d48, checker=<optimized out>, arg=0x14ad00067440 "\001") at /test/10.5_dbg/sql/item.cc:7777 #9 0x0000557d48229751 in pushdown_cond_for_derived (thd=0x14ad00000d48, cond=0x14ad00017840, derived=derived@entry=0x14ad00014a90) at /test/10.5_dbg/sql/sql_derived.cc:1526 #10 0x0000557d482fa46e in JOIN::optimize_inner (this=this@entry=0x14ad00015f90) at /test/10.5_dbg/sql/sql_select.cc:2229 #11 0x0000557d482faf77 in JOIN::optimize (this=this@entry=0x14ad00015f90) at /test/10.5_dbg/sql/sql_select.cc:1765 #12 0x0000557d482fb04f in mysql_select (thd=thd@entry=0x14ad00000d48, tables=0x14ad00014a90, fields=@0x14ad00012fe0: {<base_list> = {<Sql_alloc> = {<No data fields>}, first = 0x14ad00013488, last = 0x14ad00017538, elements = 2}, <No data fields>}, conds=0x14ad00015380, og_num=0, order=0x0, group=0x0, having=0x0, proc_param=0x0, select_options=2147748608, result=0x14ad00015f68, unit=0x14ad00004ef8, select_lex=0x14ad00012e78) at /test/10.5_dbg/sql/sql_select.cc:4897 #13 0x0000557d482fbba5 in handle_select (thd=thd@entry=0x14ad00000d48, lex=lex@entry=0x14ad00004e30, result=result@entry=0x14ad00015f68, setup_tables_done_option=setup_tables_done_option@entry=0) at /test/10.5_dbg/sql/sql_select.cc:449 #14 0x0000557d48273f44 in execute_sqlcom_select (thd=thd@entry=0x14ad00000d48, all_tables=0x14ad00014a90) at /test/10.5_dbg/sql/sql_parse.cc:6425 #15 0x0000557d48280fba in mysql_execute_command (thd=thd@entry=0x14ad00000d48) at /test/10.5_dbg/sql/sql_parse.cc:4030 #16 0x0000557d4826d280 in mysql_parse (thd=thd@entry=0x14ad00000d48, rawbuf=<optimized out>, length=<optimized out>, parser_state=parser_state@entry=0x14ad5cd082c0, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_parse.cc:8223 #17 0x0000557d4827bfc5 in dispatch_command (command=command@entry=COM_QUERY, thd=thd@entry=0x14ad00000d48, packet=packet@entry=0x14ad0000aa19 "SELECT * FROM (SELECT * FROM t) AS t WHERE a=''", packet_length=packet_length@entry=47, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_class.h:1329 #18 0x0000557d4827ecfe in do_command (thd=0x14ad00000d48) at /test/10.5_dbg/sql/sql_parse.cc:1376 #19 0x0000557d483cbd26 in do_handle_one_connection (connect=<optimized out>, connect@entry=0x557d4c5a7d68, put_in_cache=put_in_cache@entry=true) at /test/10.5_dbg/sql/sql_connect.cc:1417 #20 0x0000557d483cc3c4 in handle_one_connection (arg=arg@entry=0x557d4c5a7d68) at /test/10.5_dbg/sql/sql_connect.cc:1319 #21 0x0000557d4884be57 in pfs_spawn_thread (arg=0x557d4c58aad8) at /test/10.5_dbg/storage/perfschema/pfs.cc:2201 #22 0x000014ad73925609 in start_thread (arg=<optimized out>) at pthread_create.c:477 #23 0x000014ad73511133 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 Bug confirmed present in: MariaDB: 10.5.26 (dbg), 10.6.19 (dbg) Bug (or feature/syntax) confirmed not present in: MariaDB: 10.5.26 (opt), 10.6.19 (opt), 10.11.9 (dbg), 10.11.9 (opt), 11.1.6 (dbg), 11.1.6 (opt), 11.2.5 (dbg), 11.2.5 (opt), 11.4.3 (dbg), 11.4.3 (opt), 11.5.2 (dbg), 11.5.2 (opt)

Ramesh Sivaraman added a comment - 2024-07-22 12:03 Another test case SET optimizer_switch= 'derived_merge=off,condition_pushdown_for_derived=on' ; CREATE TABLE t (a INT ); SELECT * FROM ( SELECT a-23 AS a FROM t WHERE a=23) AS t WHERE a= '8' ; Unique ID typeid(*copy) == typeid(*this)|SIGABRT|Item::get_copy|Item_int::do_build_clone|Item::build_clone|Item_equal::create_pushable_equalities

Oleg Smirnov added a comment - 2024-07-23 08:57 New runtime diagnostic introduced with MDEV-34490 has detected that Item_int_with_ref incorrectly returns an instance of its ancestor class Item_int. This commit fixes that. In addition, this commit reverts a part of the diagnostic related to clone_item() checks. As it turned out, clone_item() is not required to return an object of the same class as the cloned one. For example, look at Item_param::clone_item(): it can return objects of Item_null, Item_int, Item_string, etc, depending on the object state. So the runtime type diagnostic is not applicable to clone_item() and is disabled with this commit. As the similar diagnostic failures are expected to appear again in the future, this commit introduces a new test file in the main suite: item_types.test, and new test cases may be added to this file The pull request is created. sanja , can you please review it?

Oleksandr Byelkin added a comment - 2024-07-23 12:24 OK to push after fixing comment

Oleg Smirnov added a comment - 2024-07-23 14:56 Pushed to 10.5