A code contribution introduced a wrapper safe_strcpy() for the standard library function strncpy(). This wrapper is checking whether the output was truncated even in cases where the caller does not care about it.
I think that we need a separate function for those few occurrences where the caller cares about truncation.
While I was investigating this, I noticed that the program client/mariadb-plugin is apparently not covered by the default test suites of our mtr tool.
- causes
-
MDEV-34755
GCC -Wstringop-truncation due to safe_strcpy()
-
-
Closed
{"report":{"fcp":1549.2000002861023,"ttfb":426.90000009536743,"pageVisibility":"visible","entityId":129374,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":32,"apdex":0.5,"journeyId":"e367516c-52e8-4844-8953-7203c5d17666","navigationType":0,"readyForUser":1647.5999999046326,"redirectCount":0,"resourceLoadedEnd":2137.0999999046326,"resourceLoadedStart":434.7000002861023,"resourceTiming":[{"duration":425.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":434.7000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":434.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":860.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":425.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":435,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":435,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":860.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":454.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":435.2000002861023,"connectEnd":435.2000002861023,"connectStart":435.2000002861023,"domainLookupEnd":435.2000002861023,"domainLookupStart":435.2000002861023,"fetchStart":435.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":435.2000002861023,"responseEnd":890,"responseStart":890,"secureConnectionStart":435.2000002861023},{"duration":609.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":435.40000009536743,"connectEnd":435.40000009536743,"connectStart":435.40000009536743,"domainLookupEnd":435.40000009536743,"domainLookupStart":435.40000009536743,"fetchStart":435.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":435.40000009536743,"responseEnd":1044.9000000953674,"responseStart":1044.9000000953674,"secureConnectionStart":435.40000009536743},{"duration":615.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":435.59999990463257,"connectEnd":435.59999990463257,"connectStart":435.59999990463257,"domainLookupEnd":435.59999990463257,"domainLookupStart":435.59999990463257,"fetchStart":435.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":435.59999990463257,"responseEnd":1051.0999999046326,"responseStart":1051.0999999046326,"secureConnectionStart":435.59999990463257},{"duration":616.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":435.80000019073486,"connectEnd":435.80000019073486,"connectStart":435.80000019073486,"domainLookupEnd":435.80000019073486,"domainLookupStart":435.80000019073486,"fetchStart":435.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":435.80000019073486,"responseEnd":1052,"responseStart":1052,"secureConnectionStart":435.80000019073486},{"duration":616.3000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":436,"connectEnd":436,"connectStart":436,"domainLookupEnd":436,"domainLookupStart":436,"fetchStart":436,"redirectEnd":0,"redirectStart":0,"requestStart":436,"responseEnd":1052.3000001907349,"responseStart":1052.3000001907349,"secureConnectionStart":436},{"duration":636.1999998092651,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":436.2000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":436.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1072.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":616.5,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":436.40000009536743,"connectEnd":436.40000009536743,"connectStart":436.40000009536743,"domainLookupEnd":436.40000009536743,"domainLookupStart":436.40000009536743,"fetchStart":436.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":436.40000009536743,"responseEnd":1052.9000000953674,"responseStart":1052.9000000953674,"secureConnectionStart":436.40000009536743},{"duration":636.2000002861023,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":436.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":436.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1072.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":617,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":436.7000002861023,"connectEnd":436.7000002861023,"connectStart":436.7000002861023,"domainLookupEnd":436.7000002861023,"domainLookupStart":436.7000002861023,"fetchStart":436.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":436.7000002861023,"responseEnd":1053.7000002861023,"responseStart":1053.7000002861023,"secureConnectionStart":436.7000002861023},{"duration":991.3000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":448.5,"connectEnd":448.5,"connectStart":448.5,"domainLookupEnd":448.5,"domainLookupStart":448.5,"fetchStart":448.5,"redirectEnd":0,"redirectStart":0,"requestStart":448.5,"responseEnd":1439.8000001907349,"responseStart":1439.7000002861023,"secureConnectionStart":448.5},{"duration":1688.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":448.59999990463257,"connectEnd":448.59999990463257,"connectStart":448.59999990463257,"domainLookupEnd":448.59999990463257,"domainLookupStart":448.59999990463257,"fetchStart":448.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":448.59999990463257,"responseEnd":2137.0999999046326,"responseStart":2137.0999999046326,"secureConnectionStart":448.59999990463257},{"duration":402.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1100.4000000953674,"connectEnd":1100.4000000953674,"connectStart":1100.4000000953674,"domainLookupEnd":1100.4000000953674,"domainLookupStart":1100.4000000953674,"fetchStart":1100.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":1100.4000000953674,"responseEnd":1503,"responseStart":1503,"secureConnectionStart":1100.4000000953674},{"duration":624.6999998092651,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1540.2000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1540.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2164.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":682.3000001907349,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1572.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1572.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2254.800000190735,"responseStart":0,"secureConnectionStart":0},{"duration":609.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1576.8000001907349,"connectEnd":1576.8000001907349,"connectStart":1576.8000001907349,"domainLookupEnd":1576.8000001907349,"domainLookupStart":1576.8000001907349,"fetchStart":1576.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":1576.8000001907349,"responseEnd":2186,"responseStart":2186,"secureConnectionStart":1576.8000001907349},{"duration":616.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1578.3000001907349,"connectEnd":1578.3000001907349,"connectStart":1578.3000001907349,"domainLookupEnd":1578.3000001907349,"domainLookupStart":1578.3000001907349,"fetchStart":1578.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":1578.3000001907349,"responseEnd":2195.0999999046326,"responseStart":2195.0999999046326,"secureConnectionStart":1578.3000001907349}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":274,"responseStart":427,"responseEnd":441,"domLoading":433,"domInteractive":2170,"domContentLoadedEventStart":2170,"domContentLoadedEventEnd":2255,"domComplete":3914,"loadEventStart":3914,"loadEventEnd":3916,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2144.9000000953674},{"name":"bigPipe.sidebar-id.end","time":2145.800000190735},{"name":"bigPipe.activity-panel-pipe-id.start","time":2146.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":2150.800000190735},{"name":"activityTabFullyLoaded","time":2364.800000190735}],"measures":[],"correlationId":"8960d54199ee63","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":12,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}